[HACKERS] PG_DIAG_SEVERITY and a possible bug in pq_parse_errornotice()

2016-08-25 Thread Jakob Egger
Hi, My PostgreSQL client checks the PG_DIAG_SEVERITY error field to determine the error level. However, I have now learned that this field is localized. This means that a server configured with --enable-nls might for example return the string ERREUR instead of ERROR. So if I want to determine

[HACKERS] sslmode=require fallback

2016-06-16 Thread Jakob Egger
Hi! I've looked at the way libpq handles TLS certificates and plaintext fallback, and I am somewhat surprised. The default ssmode is prefer. According to the documentation, this will make libpq use an SSL connection if possible, but will use a plain text connection as a fallback. The certifica

[HACKERS] Refactor pg_dump as a library?

2016-04-14 Thread Jakob Egger
Would anybody else be interested in a pg_dump library? I've found a thread from 2013 related to the idea, but the discussion came to nothing. Thread started here: http://www.postgresql.org/message-id/71e01949.2e16b.13df4707405.coremail.shuai900...@126.com My Motivation: I'm the developer of a

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-27 Thread Jakob Egger
Am 26.11.2014 um 17:46 schrieb Geoff Montee : > This topic reminds me of a thread from a couple months ago: > > http://www.postgresql.org/message-id/f8268db6-b50f-429f-8289-da8ffa5f2...@tripadvisor.com > > It sounds like adding ICU support to core may also allow for adding > collation versioning

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
> Is it broken *worse* in 9.4 than it was in previous versions? No. Because the indices need to be rebuilt, the only realistic opportunity for applying this patch to Postgres.app is when releasing a major new version, since then people need to migrate their data anyway. That's why I wanted to

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
> Am 26.11.2014 um 11:20 schrieb Dave Page : > > On Wed, Nov 26, 2014 at 10:13 AM, Jakob Egger wrote: >> Am 26.11.2014 um 11:05 schrieb Dave Page : >> >> You may want to bear in mind that postgres.app is on the main PG >> downloads page on the website. If

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
Am 26.11.2014 um 11:05 schrieb Dave Page : > You may want to bear in mind that postgres.app is on the main PG > downloads page on the website. If you're patching Postgres to add a > feature like this, it would become a fork and would have to be moved > out of the "PostgreSQL Core Distribution" sect

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
> Bear in mind that this might alter the way indexes are built. From the top of > my head, I just can't remember if this is true or not. I'm probably wrong? > Magnus? You would have to try. That's why I want to include it in the first version of 9.4, when people need to dump & reload their dat

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
> One of the > big arguments against bringing it in then (because it worked) was that > we'd bring in another compile time dependency that's actually larger > than PostgreSQL itself. Magnus: I don't see how this is a problem as long as using ICU is *optional*. On systems with a working strcoll th

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Jakob Egger
o questions: >> >> 1) Does anybody else have experience with this patch? Is it safe to release >> PostgreSQL binaries with this patch applied to the public? >> >> 2) Is there a reason why this patch hasn't been merged into core over the >> years? Since it requires setting a configure switch (--with-icu) it >> shouldn't break anything? >> >> Best regards, >> Jakob Egger >> >>

[HACKERS] Palle Girgensohn's ICU patch

2014-11-25 Thread Jakob Egger
th-icu) it shouldn't break anything? Best regards, Jakob Egger