Re: [HACKERS] Patch: Optimize memory allocation in function 'bringetbitmap'

2015-10-16 Thread Jinyu Zhang
Update the patch_brin_optimze_mem according to your comment. At 2015-10-16 10:13:35, "Alvaro Herrera" wrote: >zhangjinyu wrote: > >> However I wonder if it would be simpler to have the dtup structure have >> the pointers, so that you can pass it as NULL

[HACKERS] BRIN Scan: Optimize memory allocation in function 'bringetbitmap'

2015-09-27 Thread Jinyu Zhang
) NOT NULL); copy lineitem from '/home/jinyu/mywork/dbgen/lineitem.tbl' delimiter '|'; create index brinLineitem on lineitem using brin(L_ORDERKEY) with(pages_per_range = 1); Jinyu Zhang

[HACKERS] Patch: Optimize memory allocation in function 'bringetbitmap'

2015-09-27 Thread Jinyu Zhang
) NOT NULL); copy lineitem from '/home/jinyu/mywork/dbgen/lineitem.tbl' delimiter '|'; create index brinLineitem on lineitem using brin(L_ORDERKEY) with(pages_per_range = 1); Jinyu Zhang 网易考拉iPhone6s玫瑰金5288元，现货不加价 patch_optimize_mem Description: Binary data -- Sent via pgsql-hackers mailing

[HACKERS] Did we forget to unpin buf in function "revmap_physical_extend" ?

2015-09-11 Thread Jinyu Zhang
In function "revmap_physical_extend", should we add "ReleaseBuffer(buf);" between line 438 and 439 ? 422 else 423 { 424 if (needLock) 425 LockRelationForExtension(irel, ExclusiveLock); 426 427 buf = ReadBuffer(irel, P_NEW); 428 if