Re: [HACKERS] Possible spelling fixes

2017-03-01 Thread Josh Soref
0001-spelling-comments.patch Description: Binary data 0002-spelling-strings.patch Description: Binary data 0003-spelling-sgml.patch Description: Binary data 0004-spelling-variables.patch Description: Binary data 0005-spelling-misc.patch Description: Binary data -- Sent via pgsql-hacker

Re: [HACKERS] Possible spelling fixes

2017-03-01 Thread Josh Soref
Peter Eisentraut wrote: > Yes, some of that was committed, and some comments were offered. If > there is more to do, please send a rebased patch set. Conflicting comments were offered. And Heikki requested I send along the remainder. Which I did. Only one of those patches would have been impacted

Re: [HACKERS] Possible spelling fixes

2017-03-01 Thread Josh Soref
I'll include it. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Possible spelling fixes

2017-03-01 Thread Josh Soref
I understood that they were git commits. I could have excluded the file but opted not to in case people were willing to take a small drift -- the SHAs are what someone needs to review the commit, and personally, I'd rather read something without typos than with -- especially in a summary. But, I'll

Re: [HACKERS] Possible spelling fixes

2017-03-01 Thread Josh Soref
I can easily drop the shutdown* items; The reason for rowMarks is consistency with lr_arowMarks. I'll tentatively exclude that from any resubmission I make tonight... -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [HACKERS] Possible spelling fixes

2017-03-01 Thread Josh Soref
On Mar 1, 2017 9:06 AM, "Peter Eisentraut" wrote: On 2/6/17 06:03, Heikki Linnakangas wrote: > Ah, yes please. Post them over and I'll have a look at those as well. This thread is in the commit fest, but I think there is no current patch. I sent email on the 6th with a number of patches as att

Re: [HACKERS] Possible spelling fixes

2017-02-06 Thread Josh Soref
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -6083,7 +6083,7 @@ StartupXLOG(void) ereport(LOG, (errmsg("database system was shut

Re: [HACKERS] Possible spelling fixes

2017-02-06 Thread Josh Soref
diff --git a/src/test/regress/sql/plpgsql.sql b/src/test/regress/sql/plpgsql.sql --- a/src/test/regress/sql/plpgsql.sql +++ b/src/test/regress/sql/plpgsql.sql @@ -2219,15 +2219,15 @@ drop type eitype cascade; -- SQLSTATE and SQLERRM test -- -create function excpt_test1() returns void as $$ +cr

Re: [HACKERS] Possible spelling fixes

2017-02-06 Thread Josh Soref
diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c --- a/src/backend/access/transam/multixact.c +++ b/src/backend/access/transam/multixact.c @@ -3342,7 +3342,7 @@ pg_get_multixact_members(PG_FUNCTION_ARG } mxact; MultiXactId mxid = PG_GETA

Re: [HACKERS] Possible spelling fixes

2017-02-06 Thread Josh Soref
diff --git a/contrib/ltree/ltxtquery_io.c b/contrib/ltree/ltxtquery_io.c --- a/contrib/ltree/ltxtquery_io.c +++ b/contrib/ltree/ltxtquery_io.c @@ -96,7 +96,7 @@ gettoken_query(QPRS_STATE *state, int32 if (*flag)

Re: [HACKERS] Possible spelling fixes

2017-02-06 Thread Josh Soref
Heikki wrote: ‎> I pushed most of these. Except for the below: > optimisation -> optimization et al. > Most of our code is written with the American spelling, > but the British spelling isn't wrong, > so I don't want to go around changing them all. Sure As you'll see, my approach is to aim for c

Re: [HACKERS] Possible spelling fixes

2017-02-05 Thread Josh Soref
It's now split more or less to your suggestion: https://github.com/jsoref/postgres/commits/spelling diff --git a/configure b/configure --- a/configure +++ b/configure @@ -7088,7 +7088,7 @@ test -z "$INSTALL_SCRIPT" && INSTALL_SCR test -z "$INSTALL_DATA" && INSTALL_DATA='${INSTALL} -m 644' # Whe

[HACKERS] Possible spelling fixes

2017-02-05 Thread Josh Soref
Hi. I'm going through project-by-project offering spelling fixes. I have read your submission suggestions [1][2] and am choosing to disregard them. Could someone please review the changes I have [3] and suggest a series of commits that this project might like? It is quite likely that someone will