Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-09-19 Thread Pierre Ducroquet
On Tuesday, September 19, 2017 12:52:37 PM CEST you wrote: > On Thu, Sep 14, 2017 at 2:17 AM, Pierre Ducroquet wrote: > > All my apologies for the schockingly long time with no answer on this > > topic. > No problem. That's the concept called life I suppose. > >

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-09-18 Thread Pierre Ducroquet
On Monday, September 18, 2017 5:13:38 PM CEST Tom Lane wrote: > Ryan Murphy writes: > > Looked thru the diffs and it looks fine to me. > > Changing a lot of a integer/long arguments that were being read directly > > via atoi / atol to be read as strings first, to give better error > > handling. >

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-09-13 Thread Pierre Ducroquet
e some > whitespace issues. The conflicts in applying are quite trivial though, so > it should be easy to create a new version. Do you plan to work on this > during this Commitfest so we can move this patch forward? Yes, my bad. Attached to this email is the new version, that now applies o

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-09-13 Thread Pierre Ducroquet
On Wednesday, September 13, 2017 6:01:43 PM CEST you wrote: > > On 15 May 2017, at 07:26, Michael Paquier > > wrote:> > > On Tue, May 2, 2017 at 2:28 AM, Pierre Ducroquet wrote: > >> I will submit this patch in the current commit fest. > > > > I ha

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-05-01 Thread Pierre Ducroquet
On Friday, April 7, 2017 3:12:58 AM CEST, Kyotaro HORIGUCHI wrote: Hi, Pierre. Maybe you're the winner:p At Thu, 06 Apr 2017 12:34:09 +0200, Pierre Ducroquet wrote in <1714428.BHRm6e8A2D@peanuts2> On Thursday, April 6, 2017 2:00:55 PM CEST Kyotaro HORIGUCHI wrote: ... That bei

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-04-22 Thread Pierre Ducroquet
On Saturday, April 22, 2017 11:31:58 PM CEST Michael Paquier wrote: > On Sat, Apr 22, 2017 at 11:12 PM, Pierre Ducroquet wrote: > > Following your advice, I went through the source tree and cleaned up most > > instances of that pattern. > > I have attached the correspondi

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-04-22 Thread Pierre Ducroquet
On Friday, April 14, 2017 8:59:03 AM CEST Robert Haas wrote: > On Fri, Apr 14, 2017 at 2:32 AM, Pierre Ducroquet wrote: > > On Friday, April 14, 2017 8:44:37 AM CEST Michael Paquier wrote: > >> On Fri, Apr 14, 2017 at 6:32 AM, Pierre Ducroquet > > > > wrote: >

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-04-14 Thread Pierre Ducroquet
On Friday, April 14, 2017 8:59:03 AM CEST Robert Haas wrote: > On Fri, Apr 14, 2017 at 2:32 AM, Pierre Ducroquet wrote: > > On Friday, April 14, 2017 8:44:37 AM CEST Michael Paquier wrote: > >> On Fri, Apr 14, 2017 at 6:32 AM, Pierre Ducroquet > > > > wrote: >

Re: [HACKERS] Small patch for pg_basebackup argument parsing

2017-04-13 Thread Pierre Ducroquet
On Friday, April 14, 2017 8:44:37 AM CEST Michael Paquier wrote: > On Fri, Apr 14, 2017 at 6:32 AM, Pierre Ducroquet wrote: > > Yesterday while doing a few pg_basebackup, I realized that the integer > > parameters were not properly checked against invalid input. > > It is

[HACKERS] Small patch for pg_basebackup argument parsing

2017-04-13 Thread Pierre Ducroquet
next commit fest or is it not needed for such small patches ? Thanks PierreFrom c5301085514b8e5acd9ffa5b10ae6521677b4d72 Mon Sep 17 00:00:00 2001 From: Pierre Ducroquet Date: Thu, 13 Apr 2017 23:25:51 +0200 Subject: [PATCH] Check the results of atoi in pg_basebackup Passing invalid strin

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-04-06 Thread Pierre Ducroquet
On Thursday, April 6, 2017 2:00:55 PM CEST Kyotaro HORIGUCHI wrote: > At Thu, 06 Apr 2017 00:59:49 +0200, Pierre Ducroquet > wrote in <2008148.rxBNyNRHPZ@peanuts2> > > But it all gets messy when we want to create a streaming standby server > > using pg_basebackup. When ba

[HACKERS] Bug with pg_basebackup and 'shared' tablespace

2017-04-05 Thread Pierre Ducroquet
Hi On our servers, we are running different PostgreSQL versions because we can not migrate every application at the same time to Pg 9.6… Since we have several disks, we use tablespaces and, for historical reasons, we used the same folder for both Pg versions, say /mnt/ssd/postgres The server has

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-31 Thread Pierre Ducroquet
On Friday, March 31, 2017 7:17:08 AM CEST, Jan Michálek wrote: 2017-03-30 21:53 GMT+02:00 Pavel Stehule : 2017-03-29 20:11 GMT+02:00 Jan Michálek : 2017-03-27 19:41 GMT+02:00 Jan Michálek : 2017-03-23 17:26 GMT+01:00 Pierre Ducroquet : The following review has been posted through the

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-03-23 Thread Pierre Ducroquet
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Hi This is my first review (Magnus said in his presentation