Hi,
Tomas, thanks for review and comments!
> I have to admit I find the existing code a bit convoluted, particularly the
> part that deals with the (commId == negId) case. And the patch does not
> really improve the situation, quite the contrary.
>
> Perhaps it’s time to get rid of this optimi
> On 27 Feb 2016, at 03:46, Euler Taveira wrote:
> Because it is not a common practice to test catalog dependency on
> separate tests (AFAICS initial catalogs are tested with oidjoins.sql).
> Also, your test case is too huge for such a small use case.
It seems oidjoins.sql is automatically gener
Thanks for comments, Euler!
> ... is hard to understand. Instead, you could separate the conditional
> expression into a variable.
Fixed the patch to be more descriptive and to avoid repeating same
computation over and over again. See v2 of the patch attached.
> I don't think those are mandato
Hello, hackers!
As was mentioned in that message [1], and earlier in [2], DROPping OPERATOR with
negator or commutator doesn't update respective fields (oprnegate and oprcom) on
them. While this issue is probably not very frequent, this behaviour leaves
database in inconsistent state and prevents
