which I tried to do review) would be beneficial.
For now I'm not sure what is going on with pglogical,
and whether my review even mattered.
Best regards
Tomasz Rybak
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
.
Of course ability to change storage subsystem might
help with experimentation, but even now (OK, when 9.6 is out)
we might use increased IO concurrency.
--
Tomasz Rybak GPG/PGP key ID: 2AD5 9860
Fingerprint A481 824E 7DD3 9C0E C40A 488E C654 FB33 2AD5 9860
http://member.acm.org/~tomaszrybak
signature.asc
Description: This is a digitally signed message part
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Final part of review:
protocol.txt
+|origin_identifier|signed char[origin_id
t; > + hentry = (struct PGLRelMetaCacheEntry*)
> > hash_search(RelMetaCache,
> > +
> > (void *)(&RelationGetRelid(rel)),
> > +
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Documentation - although I haven't yet went through protocol documentation:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
I revied more files:
pglogical_proto_native.c
+ pq_sendbyte(o
W dniu 20.01.2016, śro o godzinie 13∶54 +0800, użytkownik Craig Ringer
napisał:
> On 20 January 2016 at 06:23, Tomasz Rybak
> wrote:
> > The following review has been posted through the commitfest
> > application:
> >
> Thanks!
>
> >
> > +
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
First part of code review (for about 1/3rd of code):
pglogical_output.h:
+ /
I just quickly went through patch v5.
It's rather big patch, on (or beyond) my knowledge of PostgreSQL to perform
high-quality review. But during this week I'll try to send reviews of parts of
the code, as going through it in one sitting seems impossible.
One proposed change - update copyright t
ut at the same time I can only check whether code looks
correct, applies cleanly, whether it compiles, whether
tests pass.
I do not see bigger picture - and also cannot see emails with
discussion about long- or mid-term direction or vision.
It makes harder to feel that it matters and to decide
which
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation:tested, failed
Applies cleanly on current master (b416c0bb622ce5d33fdbec3bbce0045113
9.4 and 9.5
compatibility needed in README.md and README.plhooks?
It's not much text, but I'm not sure whether they shouldn't be
removed for 9.6-targeting change.
--
Tomasz Rybak GPG/PGP key ID: 2AD5 9860
Fingerprint A481 824E 7DD3 9C0E C40A 488E C654 FB33 2AD5 9860
http://member.
12 matches
Mail list logo
