On Mon, Oct 2, 2017 at 8:31 PM, Daniel Gustafsson wrote:
> > On 13 Sep 2017, at 07:44, Vaishnavi Prabakaran <
> vaishnaviprabaka...@gmail.com> wrote:
> >
> > On Wed, Sep 13, 2017 at 3:33 PM, Craig Ringer <mailto:cr...@2ndquadrant.com>> wrote:
> >
>
Hi,
On Sat, Sep 9, 2017 at 1:29 PM, Haribabu Kommi
wrote:
>
> Fixed patch is attached.
>
Patch applies and has lot of noise due to indent with spaces.
I did ran regression tests located in - src/test/regress,
src/test/modules/test_pg_dump, src/bin/pg_dump, src/bin/pg_upgrade folders
and no is
On Tue, Sep 26, 2017 at 11:45 AM, Michael Paquier wrote:
> On Tue, Sep 26, 2017 at 9:04 AM, Vaishnavi Prabakaran
> wrote:
> > Yes, I did realize on further reading the patch and what led to the
> > confusion is that in the 3rd patch , updated documentation(copied below)
&
Hi,
On Wed, Sep 13, 2017 at 9:59 AM, Daniel Gustafsson wrote:
>
> I’m not entirely sure why this was flagged as "Waiting for Author” by the
> automatic run, the patch applies for me and builds so resetting back to
> “Needs
> review”.
>
>
This patch applies and build cleanly and I did a testing w
Hi,
On Tue, Sep 19, 2017 at 5:12 PM, Michael Paquier
wrote:
>
> >>@@ -163,22 +150,16 @@ lo_read(int fd, char *buf, int len)
> >>
> >> + if ((lobj->flags & IFS_RDLOCK) == 0)
> >>+ ereport(ERROR,
> >>+ (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
> >>+ errmsg("large object descriptor %
Hi,
Backend's lo_functions were renamed to avoid conflicting with libpq
prototypes in commit - 6fc547960dbe0b8bd6cefae5ab7ec3605a5c46fc.
Logs inside those functions still refer to old symbol names, Here is the
small patch to update the same.
Thanks & Regards,
Vaishnavi,
Fujitsu Australia.
000
Hi,
On Mon, Aug 14, 2017, Michael Paquier wrote:
>Attached is a set of 3 patches:
I tried to review the patch and firstly patch applies cleanly without any
noise.
>- 0001 removes ALLOW_DANGEROUS_LO_FUNCTIONS
I think it is better to remove "ALLOW_DANGEROUS_LO_FUNCTIONS" from
pg_config_manual.
On Wed, Sep 13, 2017 at 3:33 PM, Craig Ringer wrote:
>
> I really do not like calling it "commit" as that conflates with a database
> commit.
>
> A batch can embed multiple BEGINs and COMMITs. It's entirely possible for
> an earlier part of the batch to succeed and commit, then a later part to
>
On Wed, Aug 23, 2017 at 7:40 PM, Andres Freund wrote:
>
>
>
> > Am failing to see the benefit in allowing user to set
> > PQBatchAutoFlush(true|false) property? Is it really needed?
>
> I'm inclined not to introduce that for now. If somebody comes up with a
> convincing usecase and numbers, we ca
Andres Freund wrote :
> If you were to send a gigabyte of queries, it'd buffer them all up in
memory... So some
>more intelligence is going to be needed.
Firstly, sorry for the delayed response as I got busy with other
activities.
To buffer up the queries before flushing them to the socket, I thi
On Tue, Jun 20, 2017 at 8:49 AM, Andres Freund wrote:
> On 2017-04-05 15:45:26 -0700, Andres Freund wrote:
> > Hi,
> >
> > On 2017-04-05 17:00:42 +1000, Vaishnavi Prabakaran wrote:
> > > Regarding test patch, I have corrected the test suite after David
> Steel
On Mon, May 22, 2017 at 5:10 PM, Michael Paquier
wrote:
> If the protocol version is SSL
> 3.0 or TLS 1.0, this result code is returned only if a closure alert
> has occurred in the protocol, i.e. if the connection has been closed
> cleanly. Note that in this case SSL_ERROR_ZERO_RETURN does not
>
On Thu, May 18, 2017 at 2:56 AM, Surafel Temesgen
wrote:
> Sorry for being very late. I also think guc version of the patch can be
> acceptable and useful.
>
> I modified the patch as such and added to commitfest 2017-07.
>
>
>
You need documentation changes in "libpq - C Library" chapter's PQexe
On Wed, May 17, 2017 at 3:52 AM, Alvaro Herrera
wrote:
> Tom Lane wrote:
>
> > BTW, it would be a good idea for somebody to check this out on Windows,
> > assuming there's a way to generate a keyboard EOF signal there.
>
> I last used a Windows command line almost two decades ago now, but
> Ctrl-
On Tue, May 16, 2017 at 8:40 AM, Thomas Munro wrote:
>
> I you hit ^d while COPY FROM STDIN is reading then subsequent COPY
> FROM STDIN commands return immediately.
Hi, I could not reproduce this issue. Even after Ctrl+d , subsequent COPY
from commands reads the input properly. Is there any sp
On Wed, May 10, 2017 at 5:58 PM, Heikki Linnakangas wrote:
> On 05/10/2017 08:01 AM, Michael Paquier wrote:
>
>> On Wed, May 10, 2017 at 10:51 AM, Vaishnavi Prabakaran
>> wrote:
>>
>>> Following recent removal of support to store password in plain text,
&
Hi All,
Following recent removal of support to store password in plain text,
modified the code to
1. Remove "PASSWORD_TYPE_PLAINTEXT" macro
2. Instead of using "get_password_type" to retrieve the encryption method
AND to check if the password is already encrypted or not, modified the code
to
a.
On Tue, May 2, 2017 at 11:30 PM, Andrew Dunstan <
andrew.duns...@2ndquadrant.com> wrote:
>
> Here's a simple patch that does what I had in mind. It allows providing
> for an arbitrary schedule file in both the check and installcheck
> recipes. The historic behaviour is preserved.
>
>
Hmm, installc
On Mon, May 1, 2017 at 11:01 PM, Andrew Dunstan <
andrew.duns...@2ndquadrant.com> wrote:
>
>
> In the absence of further comments I'm going to apply this and
> back-patch it so we can get a significant improvement in how the
> buildfarm reports results from TAP tests, as well as increased coverage
On Wed, Apr 26, 2017 at 9:52 PM, Magnus Hagander
wrote:
>
> I wonder if we should also consider changing the standby error message to
> be a WARNING instead of an ERROR. So that if you try to start up a standby
> with hot_standby=on but master with wal_level=replica it would turn into a
> cold st
Hi All,
Regarding the discussion about Autonomous transaction in below message ID,
long time ago, it has been specified that having a new structure "Struct
PGAutonomousXACT" was rejected in PGCon hackers meeting. Can anyone know
why is it been rejected? What is the disadvantage/problem identified
Hi,
On Tue, Apr 4, 2017 at 7:05 AM, Andres Freund wrote:
> On 2017-04-03 14:10:47 +1000, Vaishnavi Prabakaran wrote:
> > > The CF has been extended until April 7 but time is still growing short.
> > > Please respond with a new patch by 2017-04-04 00:00 AoE (UTC-12) or
&g
On Sat, Apr 1, 2017 at 2:03 AM, David Steele wrote:
> Hi,
>
> On 3/30/17 2:12 PM, Daniel Verite wrote:
>
>> Vaishnavi Prabakaran wrote:
>>
>> Hmm, With batch mode, after sending COPY command to server(and server
>>> started processing the query and
On Thu, Mar 30, 2017 at 12:08 PM, Michael Paquier wrote:
> On Wed, Mar 29, 2017 at 12:40 PM, Vaishnavi Prabakaran
> wrote:
> > Michael Paquier wrote:
> >>Could you as well update src/tools/msvc/vcregress.pl, aka the routine
> >>modulescheck so as this new test is
Thanks Craig and Michael for confirming that "PQsetSingleRowMode" should be
called right after "PQbatchQueueProcess".
Michael Paquier wrote:
> It seems to me that
>this should also be effective only during the fetching of one single
>result set. When the client moves on to the next item in the qu
On Fri, Mar 17, 2017 at 12:37 AM, Daniel Verite
wrote:
> Vaishnavi Prabakaran wrote:
>
> > So, attached the alternative fix for this issue.
> > Please share me your thoughts.
>
> I assume you prefer the alternative fix because it's simpler.
>
I would l
On Tue, Mar 14, 2017 at 5:50 PM, Vaishnavi Prabakaran <
vaishnaviprabaka...@gmail.com> wrote:
>
>
> On Tue, Mar 14, 2017 at 4:19 AM, Daniel Verite
> wrote:
>
>>
>> I mean the next iteration of the above while statement. Referring
>> to the doc, that would
On Tue, Mar 14, 2017 at 4:19 AM, Daniel Verite
wrote:
>
> I mean the next iteration of the above while statement. Referring
> to the doc, that would be the "next batch entry":
>
> " To get the result of the first batch entry the client must call
>PQbatchQueueProcess. It must then call PQget
On Sat, Mar 11, 2017 at 12:52 AM, Daniel Verite
wrote:
> Hi,
>
> I notice that PQsetSingleRowMode() doesn't work when getting batch results.
>
> The function is documented as:
> " int PQsetSingleRowMode(PGconn *conn);
>
> This function can only be called immediately after PQsendQuery or one
>
On Wed, Mar 8, 2017 at 3:52 AM, Daniel Verite
wrote:
> Vaishnavi Prabakaran wrote:
>
> > Yes, I have created a new patch entry into the commitfest 2017-03 and
> > attached the latest patch with this e-mail.
>
> Please find attached a companion patch imple
30 matches
Mail list logo
