Re: [HACKERS] [JDBC] SEGFAULT in HEAD with replication

2017-01-19 Thread Vladimir Gordiychuk
Core dump was extracted from this build https://travis-ci.org/Gordiychuk/pgjdbc/builds/193318018 2017-01-19 17:38 GMT+03:00 Vladimir Gordiychuk : > Last success build from postgresql HEAD was 20 days ago > https://travis-ci.org/pgjdbc/pgjdbc/builds/187764274 > We detect this problem 3

Re: [HACKERS] [JDBC] SEGFAULT in HEAD with replication

2017-01-19 Thread Vladimir Gordiychuk
Last success build from postgresql HEAD was 20 days ago https://travis-ci.org/pgjdbc/pgjdbc/builds/187764274 We detect this problem 3 days ago. 2017-01-19 17:22 GMT+03:00 Dave Cramer : > The travis job https://travis-ci.org/pgjdbc/pgjdbc/jobs/192517342 is > seeing a segfault when we are testing a

Re: [HACKERS] Logical decoding and walsender timeouts

2016-10-31 Thread Vladimir Gordiychuk
>>> When sending a big message, WalSndWriteData() notices that it's >>> approaching timeout and tries to send a keepalive request, but the >>> request just gets buffered behind the remaining output plugin data and >>> isn't seen by the client until the client has received the rest of the >>> pendin

Re: [HACKERS] Stopping logical replication protocol

2016-10-21 Thread Vladimir Gordiychuk
Craig, Andres what do you thinks about previous message? 2016-10-06 0:35 GMT+03:00 Vladimir Gordiychuk : > > Vladimir? I'm running out of time to spend on this at least until the next > CF. Think you can make these changes? > > Yes, I can. But I thinks It sho

Re: [HACKERS] Query cancel seems to be broken in master since Oct 17

2016-10-18 Thread Vladimir Gordiychuk
>What platform does the postgres server run on? Ubuntu OS name: "linux", version: "3.19.0-66-generic", arch: "amd64", family: "unix" 2016-10-18 11:05 GMT+03:00 Magnus Hagander : > > > On Tue, Oct 18, 2016 at 1:00 AM, Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > >> Hi, >> >> In pgj

Re: [HACKERS] Stopping logical replication protocol

2016-10-05 Thread Vladimir Gordiychuk
ops replication when decodes huge transaction. 2016-10-05 13:06 GMT+03:00 Craig Ringer : > On 5 October 2016 at 05:14, Andres Freund wrote: > > Hi, > > > > On 2016-09-23 13:01:27 +0800, Craig Ringer wrote: > >> From f98f2388c57d938ebbe07ccd2dbe02138312858f Mon Sep 17 00:00:00

Re: [HACKERS] Stopping logical replication protocol

2016-10-04 Thread Vladimir Gordiychuk
: > > > > On Tue, Sep 27, 2016 at 11:05 AM, Craig Ringer > wrote: > > > On 26 September 2016 at 21:52, Vladimir Gordiychuk > wrote: > > >>>You should rely on time I tests as little as possible. Some of the > test > > >>> hosts are VERY slow

Re: [HACKERS] Stopping logical replication protocol

2016-09-26 Thread Vladimir Gordiychuk
, before this changes stopping logical replication gets N ms but after apply changes it gets NN ms where NN ms less than N ms. Is it available add this kind of benchmark to postgresql? I will be grateful for links. 2016-09-26 5:32 GMT+03:00 Craig Ringer : > On 26 Sep. 2016 02:16, "Vladimir Go

Re: [HACKERS] Stopping logical replication protocol

2016-09-25 Thread Vladimir Gordiychuk
celTime) <= 3, # allow extra time for slow machines "pg_recvlogical exited promptly on sigint when idle" ); ``` Also I do not understand why we do $proc->pump while $proc->pumpable; after send signal to process, why we can not just wait stop replication slot? 2016-09-

Re: [HACKERS] Stopping logical replication protocol

2016-09-18 Thread Vladimir Gordiychuk
immediately without wait CopyDone from server. 0004 patch contain regression tests on scenarios that fix 0001 and 0002 patches. 2016-09-16 10:11 GMT+03:00 Vladimir Gordiychuk : > >Have you had a chance to look at adding the tests we discussed? > > Not yet. I plane do it on this weekends

Re: [HACKERS] Stopping logical replication protocol

2016-09-16 Thread Vladimir Gordiychuk
>Have you had a chance to look at adding the tests we discussed? Not yet. I plane do it on this weekends 2016-09-16 4:37 GMT+03:00 Craig Ringer : > On 9 September 2016 at 12:03, Craig Ringer wrote: > > > Setting "waiting on author" in CF per discussion of the need for tests. > > Have you had a

Re: [HACKERS] Stopping logical replication protocol

2016-09-08 Thread Vladimir Gordiychuk
9-08 12:29 GMT+03:00 Craig Ringer : > On 7 September 2016 at 15:44, Vladimir Gordiychuk > wrote: > > > Fixed patch in attach. > > It'd helpful if you summarize the changes made when posting revisions. > > >> * There are no tests. I don't see any really simple way

Re: [HACKERS] Stopping logical replication protocol

2016-09-07 Thread Vladimir Gordiychuk
There are no tests. I don't see any really simple way to test this, > though. > > I suggest that you apply these updated/split patches to a fresh copy > of master then see if you can update it based on this feedback. > Something like: > > git checkout master > git pull >

Re: [HACKERS] Stopping logical replication protocol

2016-08-24 Thread Vladimir Gordiychuk
logical replication. 2016-05-11 7:25 GMT+03:00 Craig Ringer : > On 11 May 2016 at 06:47, Vladimir Gordiychuk wrote: > >> Same thread, I just think these are two somewhat separate changes. One is >>> just in the walsender and allows return to command mode during waiting for >&

Re: [HACKERS] Stopping logical replication protocol

2016-05-10 Thread Vladimir Gordiychuk
arison callback that stop sending. 2016-05-10 20:22 GMT+03:00 Craig Ringer : > On 11 May 2016 at 01:15, Vladimir Gordiychuk wrote: > >> in which release can be include first part? >> > > Since it's not a bug fix, I don't think it can go in before 9.7. > >

Re: [HACKERS] Stopping logical replication protocol

2016-05-10 Thread Vladimir Gordiychuk
in which release can be include first part? 2016-05-10 15:15 GMT+03:00 Craig Ringer : > On 10 May 2016 at 19:41, Vladimir Gordiychuk wrote: > >> >> Fair enough. Though I don't understand why you'd be doing this often >>> enough that you'd care about

Re: [HACKERS] Stopping logical replication protocol

2016-05-10 Thread Vladimir Gordiychuk
> Fair enough. Though I don't understand why you'd be doing this often > enough that you'd care about reopening connections. What is the problem you > are trying to solve with this? The underlying reason you need this change? > First reason it clear API in pgjdc. Second reason it ability fast enou

Re: [HACKERS] Stopping logical replication protocol

2016-05-09 Thread Vladimir Gordiychuk
> > What's your PostgreSQL community username? gordiychuk It seems like what you're also trying to allow interruption deeper than > that, when we're in the middle of processing a reorder buffer commit record > and streaming that to the client. You're introducing an is_active member > (actually a

Re: [HACKERS] Stopping logical replication protocol

2016-05-06 Thread Vladimir Gordiychuk
tion <=BE CopyData FE=> CopyDone <=BE CopyDone <=BE CopyData ... after few seconds <=BE CommandStatus(COPY 0) <=BE ReadyForQuery(I) The main idea that i want work with same connection without close it. 2016-05-06 19:45 GMT+03:00 Oleksandr Shulgin : > On Fri, May 6, 2016 at 5:2

[HACKERS] Stopping logical replication protocol

2016-05-06 Thread Vladimir Gordiychuk
> long startStopping = System.nanoTime(); > > stream.close(); > > long now = System.nanoTime(); > > long startAndStopTime = now - start; > long stopTime = now - startStopping; > > System.out.println(TimeUnit.NANOSECONDS.toMillis(startAndStopT