Re: [HACKERS] Remove old comments in dependencies.c and README.dependencies

2017-07-27 Thread atorikoshi
> Agreed. Removed those comments. Thanks for the patch. Thanks! On 2017/07/27 0:44, Alvaro Herrera wrote: atorikoshi wrote: Attached patch removes the comments about min_group_size. Agreed. Removed those comments. Thanks for the patch. -- Atsushi Torikoshi NIPPON TELEGR

[HACKERS] Remove old comments in dependencies.c and README.dependencies

2017-06-26 Thread atorikoshi
Hi, I found some comments which are not implemented. As far as I have examined, these comments refer to min_group_size, but min_group_size was decided not to adopt and removed[1], so it seems these comments also should be removed. [1]

Re: [HACKERS] Fix a typo in README.dependencies

2017-06-23 Thread atorikoshi
On 2017/06/23 6:28, Alvaro Herrera wrote: Ashutosh Bapat wrote: On Mon, Jun 5, 2017 at 8:22 AM, atorikoshi <torikoshi_atsushi...@lab.ntt.co.jp> wrote: Hi, I found below formula to compute selectivities, but I think the last Probability 'P(b=?)' should be 'P(c=?)'. P(a=?,b=?,c=?) = P

[HACKERS] Fix a typo in README.dependencies

2017-06-04 Thread atorikoshi
Hi, I found below formula to compute selectivities, but I think the last Probability 'P(b=?)' should be 'P(c=?)'. P(a=?,b=?,c=?) = P(a=?,b=?) * (d + (1-d)*P(b=?)) Attached patch fixes it, and it also adds some spaces following another formula which is on line 86 and computes P(a=?, b=?).