Re: [HACKERS] #ifdef NOT_USED

2005-06-28 Thread Tom Lane
Abhijit Menon-Sen <[EMAIL PROTECTED]> writes: >> We keep such blocks of code around in case we might need to use it >> some day. > I think that's a bad idea. Unused code should be removed with a suitable > CVS checkin comment (and perhaps a comment where the code was), The code is that comment.

Re: [HACKERS] #ifdef NOT_USED

2005-06-28 Thread Abhijit Menon-Sen
(Sorry for the delayed response. I just got home from Germany after my visit to Linuxtag, and I'm catching up with my -hackers email now.) At 2005-06-25 09:30:17 -0400, pgman@candle.pha.pa.us wrote: > > > Hi, i have found several #ifdef NOT_USED marked code... > > We keep such blocks of code aroun

Re: [HACKERS] #ifdef NOT_USED

2005-06-25 Thread Bruce Momjian
Jaime Casanova wrote: > Hi, i have found several #ifdef NOT_USED marked code... i guess this > is dead code... is safe to remove it? there is some reason you just > hide it and not remove the code? We keep such blocks of code around in case we might need to use it some day. It can be removed it t

[HACKERS] #ifdef NOT_USED

2005-06-24 Thread Jaime Casanova
Hi, i have found several #ifdef NOT_USED marked code... i guess this is dead code... is safe to remove it? there is some reason you just hide it and not remove the code? -- regards, Jaime Casanova (DBA: DataBase Aniquilator ;) ---(end of broadcast)