Re: [HACKERS] "Allow usage of huge maintenance_work_mem for GIN build" patch

2016-05-30 Thread Tom Lane
Teodor Sigaev writes: >> Are you sure this is safe, Teodor? I don't have time to study the >> patch in detail, but offhand I think that it might have been better to >> make allocatedMemory of type int64, just like the tuplesort.c memory >> accounting variables are

Re: [HACKERS] "Allow usage of huge maintenance_work_mem for GIN build" patch

2016-05-30 Thread Teodor Sigaev
--- a/src/include/access/gin_private.h +++ b/src/include/access/gin_private.h @@ -903,7 +903,7 @@ typedef struct GinEntryAccumulator typedef struct { GinState *ginstate; - longallocatedMemory; + SizeallocatedMemory; GinEntryAccumulator *entryallocator;

Re: [HACKERS] "Allow usage of huge maintenance_work_mem for GIN build" patch

2016-05-28 Thread Noah Misch
On Thu, May 12, 2016 at 11:33:24AM -0400, Robert Haas wrote: > On Fri, May 6, 2016 at 7:58 PM, Peter Geoghegan wrote: > > I noticed that commit 30bb26b5 ("Allow usage of huge > > maintenance_work_mem for GIN build") made the following modification: > > > > ---

Re: [HACKERS] "Allow usage of huge maintenance_work_mem for GIN build" patch

2016-05-12 Thread Robert Haas
On Fri, May 6, 2016 at 7:58 PM, Peter Geoghegan wrote: > I noticed that commit 30bb26b5 ("Allow usage of huge > maintenance_work_mem for GIN build") made the following modification: > > --- a/src/include/access/gin_private.h > +++ b/src/include/access/gin_private.h > @@ -903,7

[HACKERS] "Allow usage of huge maintenance_work_mem for GIN build" patch

2016-05-06 Thread Peter Geoghegan
I noticed that commit 30bb26b5 ("Allow usage of huge maintenance_work_mem for GIN build") made the following modification: --- a/src/include/access/gin_private.h +++ b/src/include/access/gin_private.h @@ -903,7 +903,7 @@ typedef struct GinEntryAccumulator typedef struct { GinState