Re: [HACKERS] [BUGS] 7.4 beta 1: SET log_statement=false

2003-08-14 Thread Bruce Momjian
[ Moved to hackers.] Tom Lane wrote: > Bertrand Petit <[EMAIL PROTECTED]> writes: > > Non superusers can set log_statement to true but can't set it > > back to false even if log_statement was false at the begining of a > > connection. > > Yeah. I think that the restrictions for USERLIMIT va

Re: [HACKERS] [BUGS] 7.4 beta 1: SET log_statement=false

2003-08-14 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Yes, I have been thinking of that. The big question is whether a > non-super user can control the reset value? He could (via PGOPTIONS) ... but since he can only increase it, there is nothing to fear. regards, tom lane

Re: [HACKERS] [BUGS] 7.4 beta 1: SET log_statement=false

2003-08-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > /* Limit non-superuser changes */ > > if (record->context == PGC_USERLIMIT && > > source > PGC_S_UNPRIVILEGED && > > newval < conf->session_val && >^^^ >

Re: [HACKERS] [BUGS] 7.4 beta 1: SET log_statement=false

2003-08-14 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > /* Limit non-superuser changes */ > if (record->context == PGC_USERLIMIT && > source > PGC_S_UNPRIVILEGED && > newval < conf->session_val && ^^^ I had in mind s/sessio

Re: [HACKERS] [BUGS] 7.4 beta 1: SET log_statement=false

2003-08-14 Thread Bertrand Petit
On Wed, Aug 13, 2003 at 06:05:46PM -0400, Bruce Momjian wrote: > I tried adding this line: > > record->session_source < PGC_S_UNPRIVILEGED && > > and it does allow you to set the variable to false if you have set it to > true in your session, but it also allows you to set it to false if it