Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-11 Thread Tom Lane
Jan Wieck <[EMAIL PROTECTED]> writes: > Either changing the command tag or let COMMIT of an aborted transaction > fail (and stay in aborted transaction state). Those are the only two > clean ways to communicate to the client "no, I cannot commit". Well, the latter would *certainly* create compat

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-11 Thread Jan Wieck
On 7/10/2004 10:54 AM, Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: > Do we want to add this to TODO: >* Issue an extra message when COMMIT completes a failed transaction No --- it's (a) wordy and (b) not responsive to the original complaint, which was that a

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Oliver Jowett
Bruce Momjian wrote: elein wrote: FYI: I'm agreeing w/Tom who is agreeing with me. The tag change should be good. I do hope people are not relying on seeing COMMIT when the transaction rolled back. It does not seem that in this case they would. If it is a problem, hopefully we will hear about it

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread elein
FYI: I'm agreeing w/Tom who is agreeing with me. The tag change should be good. I do hope people are not relying on seeing COMMIT when the transaction rolled back. It does not seem that in this case they would. elein On Sat, Jul 10, 2004 at 04:13:49PM -0400, Tom Lane wrote: > Bruce Momjian <[E

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Bruce Momjian
elein wrote: > FYI: I'm agreeing w/Tom who is agreeing with me. > > The tag change should be good. I do hope people are > not relying on seeing COMMIT when the transaction > rolled back. It does not seem that in this case > they would. If it is a problem, hopefully we will hear about it during

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > As I remember, the big issue was how often applications are looking and > comparing these tags to take actions. I think we should return ROLLBACK > on COMMIT failure and we can see if we get any problem reports during > beta. Good enough; I'll make it h

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> MOVE, FETCH, EXECUTE ... > > > Ah, yes, I remember we changed EXECUTE recently to return the tag of > > what we executed. How do we modify MOVE/FETCH tags? I can't remember. > > I was just looking to see what c

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> MOVE, FETCH, EXECUTE ... > Ah, yes, I remember we changed EXECUTE recently to return the tag of > what we executed. How do we modify MOVE/FETCH tags? I can't remember. I was just looking to see what cases ProcessUtility allowed to c

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Do we change tags in any other commands? > > MOVE, FETCH, EXECUTE ... Ah, yes, I remember we changed EXECUTE recently to return the tag of what we executed. How do we modify MOVE/FETCH tags? I can't remember. -- Bruce Momjian

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >>> I am not excited about changing the command tag. >> >> I was not either to start with, but the more I think about it, the more >> I think it would be a good idea. > What tag would we use? ABORT? No, ROLLBACK, which is what you get when you give the

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Do we change tags in any other commands? MOVE, FETCH, EXECUTE ... regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Bruce Momjian <[EMAIL PROTECTED]> writes: > >>> Do we want to add this to TODO: > >>> * Issue an extra message when COMMIT completes a failed transaction > >> > >> No --- it's (a) wordy and (b) not responsive to

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Bruce Momjian <[EMAIL PROTECTED]> writes: >>> Do we want to add this to TODO: >>> * Issue an extra message when COMMIT completes a failed transaction >> >> No --- it's (a) wordy and (b) not responsive to the original complaint, >> whi

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Do we want to add this to TODO: > > * Issue an extra message when COMMIT completes a failed transaction > > No --- it's (a) wordy and (b) not responsive to the original complaint, > which was that a client that examines command c

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-09 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Do we want to add this to TODO: > * Issue an extra message when COMMIT completes a failed transaction No --- it's (a) wordy and (b) not responsive to the original complaint, which was that a client that examines command completion tags will be eas

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-09 Thread elein
While Alvarro, et al are messing with transaction syntax this would be a good time to clarify this message. --elein On Fri, Jul 09, 2004 at 10:16:29AM -0400, Bruce Momjian wrote: > > Do we want to add this to TODO: > > * Issue an extra message when COMMIT completes a failed transaction >

Re: [HACKERS] [BUGS] BUG #1118: Misleading Commit message

2004-07-09 Thread Bruce Momjian
Do we want to add this to TODO: * Issue an extra message when COMMIT completes a failed transaction --- elein wrote: > > > > On Sun, Mar 28, 2004 at 10:23:26AM -0500, Tom Lane wrote: > > Bruce Momjian <[EMAIL PR