Re: [HACKERS] [BUGS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions

2016-05-25 Thread Alvaro Herrera
Marco Nenciarini wrote: > diff --git a/src/backend/access/heap/heapam.c > b/src/backend/access/heap/heapam.c > index eb8eada..434880a 100644 > --- a/src/backend/access/heap/heapam.c > +++ b/src/backend/access/heap/heapam.c > @@ -4764,7 +4764,13 @@ heap_xlog_freeze(XLogRecPtr lsn, XLogRecord

Re: [HACKERS] [BUGS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions

2016-05-25 Thread Marco Nenciarini
On 27/06/15 01:13, Jim Nasby wrote: > On 6/26/15 8:50 AM, Marco Nenciarini wrote: >>> >In the heap_xlog_freeze we need to subtract one to the value of >>> cutoff_xid >>> >before passing it to ResolveRecoveryConflictWithSnapshot. >>> > >>> > >>> > >> Attached a proposed patch that solves the issue.

Re: [HACKERS] [BUGS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions

2015-06-26 Thread Marco Nenciarini
Il 26/06/15 15:43, marco.nenciar...@2ndquadrant.it ha scritto: The following bug has been logged on the website: Bug reference: 13473 Logged by: Marco Nenciarini Email address: marco.nenciar...@2ndquadrant.it PostgreSQL version: 9.4.4 Operating system: all

Re: [HACKERS] [BUGS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions

2015-06-26 Thread Jim Nasby
On 6/26/15 8:50 AM, Marco Nenciarini wrote: In the heap_xlog_freeze we need to subtract one to the value of cutoff_xid before passing it to ResolveRecoveryConflictWithSnapshot. Attached a proposed patch that solves the issue. FWIW, I've reviewed the usage and the new logic looks correct.