On Mon, May 9, 2016 at 11:58 AM, Stephen Frost wrote:
> Further, this test framework was under discussion on-list and commented
> on by at least one other committer prior to being committed. It was not
> entirely without review.
No, just almost entirely without review.
--
Robert Haas
Enterpris
Catalin,
* Catalin Iacob (iacobcata...@gmail.com) wrote:
> On 5/9/16, Stephen Frost wrote:
> >> And what if the tests are buggy? New test suites should go through a
> >> CF first I think for proper review. And this is clearly one.
> >
> > They still won't result in data loss, corruption, or other
On 5/9/16, Stephen Frost wrote:
>> And what if the tests are buggy? New test suites should go through a
>> CF first I think for proper review. And this is clearly one.
>
> They still won't result in data loss, corruption, or other direct impact
> on our users, even if they are buggy. They also wo
* Michael Paquier (michael.paqu...@gmail.com) wrote:
> On Sun, May 8, 2016 at 6:44 AM, Stephen Frost wrote:
> > I do think that now is a good time for people to be reviewing what's
> > been committed, which includes writing tests (either automated ones,
> > which can be included in our test suite,
On Sun, May 8, 2016 at 6:44 AM, Stephen Frost wrote:
> I do think that now is a good time for people to be reviewing what's
> been committed, which includes writing tests (either automated ones,
> which can be included in our test suite, or one-off's for testing
> specific things but which don't m
Peter,
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> On 5/7/16 9:36 AM, Stephen Frost wrote:
> >Honestly, over the next couple of months between feature-freeze and
> >release, I'd like to add even more tests, and not just to pg_dump but
> >also to other commands that don't have ve
On 5/7/16 9:36 AM, Stephen Frost wrote:
Honestly, over the next couple of months between feature-freeze and
release, I'd like to add even more tests, and not just to pg_dump but
also to other commands that don't have very good testing today (psql, in
particular, but pg_dumpall needs more also, an
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> On 5/6/16 3:11 PM, Stephen Frost wrote:
> >These are just new tests..?
>
> This is a matter of degree, but I think there is a difference
> between new test cases and a whole new test suite.
To be clear, I've been calling it a 'test su
Tom, all,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> If you like, you can try the @contrib_excludes addition that was mentioned
> before and see if that fixes it. But if it doesn't, it's time to cut our
> losses.
Alright, it certainly *appears* to be working. All of the Windows
buildfarm animals
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Robert Haas writes:
> > On Fri, May 6, 2016 at 4:07 PM, Stephen Frost wrote:
> >> * Tom Lane (t...@sss.pgh.pa.us) wrote:
> >>> But at this point I think Peter's complaint has some force to it, and that
> >>> what you ought to do is revert the testing patch
Robert Haas writes:
> On Fri, May 6, 2016 at 4:07 PM, Stephen Frost wrote:
>> * Tom Lane (t...@sss.pgh.pa.us) wrote:
>>> But at this point I think Peter's complaint has some force to it, and that
>>> what you ought to do is revert the testing patch. You can have another go
>>> after beta1.
>> A
* Robert Haas (robertmh...@gmail.com) wrote:
> On Fri, May 6, 2016 at 4:07 PM, Stephen Frost wrote:
> > * Tom Lane (t...@sss.pgh.pa.us) wrote:
> >> Stephen Frost writes:
> >> > * Stephen Frost (sfr...@snowman.net) wrote:
> >> >> Looks like the test_pg_dump extension made the Windows builds upset.
On Fri, May 6, 2016 at 4:07 PM, Stephen Frost wrote:
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
>> Stephen Frost writes:
>> > * Stephen Frost (sfr...@snowman.net) wrote:
>> >> Looks like the test_pg_dump extension made the Windows builds upset.
>> >> I'm guessing that's because I set 'MODULES_big'
On Fri, May 6, 2016 at 3:14 PM, Andres Freund wrote:
> On 2016-05-06 15:11:53 -0400, Stephen Frost wrote:
>> * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
>> > On 5/6/16 2:06 PM, Stephen Frost wrote:
>> > >Add TAP tests for pg_dump
>> >
>> > I'd be the first to welcome this, but wha
14 matches
Mail list logo
