Re: [HACKERS] [COMMITTERS] pgsql: Default monitoring roles

2017-03-30 Thread Tom Lane
I wrote: > Simon Riggs writes: >> Weird. make check-world just skipped that directory. I guess for Dave also. > If you just did check-world, it probably didn't build contrib modules that > don't have tests, because the "check" target wouldn't do anything without > tests to run. I wondered why th

Re: [HACKERS] [COMMITTERS] pgsql: Default monitoring roles

2017-03-30 Thread Tom Lane
Simon Riggs writes: > On 30 March 2017 at 19:31, Erik Rijkers wrote: >> The buildfarm is showing red (the same errors that I get...): >> pgrowlocks.c: In function ‘pgrowlocks’: >> pgrowlocks.c:105:65: error: expected ‘)’ before ‘;’ token >> is_member_of_role(GetUserId(), DEFAULT_ROLE_STAT_SCAN_TA