Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-19 Thread Andrew Dunstan
Robert Lor wrote: Peter Eisentraut wrote: Well, yes. I meant to say, a build system that can supply the functionality of Gen_fmgrtab can surely implement this new thing. I see there is Perl being used, so it should be simple. I was thinking of using a Perl script to generate the dummy

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-19 Thread Magnus Hagander
Andrew Dunstan wrote: Robert Lor wrote: Peter Eisentraut wrote: Well, yes. I meant to say, a build system that can supply the functionality of Gen_fmgrtab can surely implement this new thing. I see there is Perl being used, so it should be simple. I was thinking of using a Perl script

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-19 Thread Andrew Dunstan
Magnus Hagander wrote: Andrew Dunstan wrote: Robert Lor wrote: Peter Eisentraut wrote: Well, yes. I meant to say, a build system that can supply the functionality of Gen_fmgrtab can surely implement this new thing. I see there is Perl being used, so it should be simple. I was

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Peter Eisentraut
Am Dienstag, 18. März 2008 schrieb Dave Page: On Mon, Mar 17, 2008 at 7:44 PM, Peter Eisentraut [EMAIL PROTECTED] wrote: Log Message: --- Enable probes to work with Mac OS X Leopard and other OSes that will support DTrace in the future. Switch from using DTRACE_PROBEn

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Dave Page
On Tue, Mar 18, 2008 at 9:40 AM, Peter Eisentraut [EMAIL PROTECTED] wrote: Do we need some support in the buildfarm to create the header file? The Windows/MSVC build system needs some adjustments. I have no idea how it works, but I'd be glad to explain the details to someone who does.

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Dave Page
On Mon, Mar 17, 2008 at 7:44 PM, Peter Eisentraut [EMAIL PROTECTED] wrote: Log Message: --- Enable probes to work with Mac OS X Leopard and other OSes that will support DTrace in the future. Switch from using DTRACE_PROBEn macros to the dynamically generated macros. Use dtrace

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Dave Page
On Tue, Mar 18, 2008 at 11:48 AM, Peter Eisentraut [EMAIL PROTECTED] wrote: Am Dienstag, 18. März 2008 schrieb Dave Page: I was actually thinking of the OS X buildfarm member I setup to exercise this. From your description it sounded like we need to generate the probe header manually if

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Peter Eisentraut
Am Dienstag, 18. März 2008 schrieb Dave Page: I was actually thinking of the OS X buildfarm member I setup to exercise this. From your description it sounded like we need to generate the probe header manually if we enable dtrace. Nope. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Alvaro Herrera
Dave Page wrote: Shouldn't there have been a doc patch with this as well? Last time I read the docs they said only Solaris supports dtrace. Well, it won't support anything else until somebody tries debugs it ;-) -- Alvaro Herrerahttp://www.CommandPrompt.com/

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Dave Page wrote: Shouldn't there have been a doc patch with this as well? Last time I read the docs they said only Solaris supports dtrace. Well, it won't support anything else until somebody tries debugs it ;-) Well, I've got Leopard here, I'd be

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Peter Eisentraut
Am Dienstag, 18. März 2008 schrieb Tom Lane: Well, I've got Leopard here, I'd be happy to test it ... but the patch has rendered http://developer.postgresql.org/pgdocs/postgres/dynamic-trace.html into a pack of lies quite independently of which OSes are supported, so I'm not very sure what to

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Robert Lor
Peter Eisentraut wrote: Well, yes. I meant to say, a build system that can supply the functionality of Gen_fmgrtab can surely implement this new thing. I see there is Perl being used, so it should be simple. I was thinking of using a Perl script to generate the dummy header file but

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Robert Lor
Peter Eisentraut wrote: Am Dienstag, 18. März 2008 schrieb Tom Lane: Well, I've got Leopard here, I'd be happy to test it ... but the patch has rendered http://developer.postgresql.org/pgdocs/postgres/dynamic-trace.html into a pack of lies quite independently of which OSes are supported, so

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Andrew Dunstan
Robert Lor wrote: Peter Eisentraut wrote: Well, yes. I meant to say, a build system that can supply the functionality of Gen_fmgrtab can surely implement this new thing. I see there is Perl being used, so it should be simple. I was thinking of using a Perl script to generate the dummy

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Robert Lor wrote: I was thinking of using a Perl script to generate the dummy header file but decided against it to avoid disrupting the build on other platforms. If sed doesn't work on Windows for some reason, we can use a Perl script instead.

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, 18 Mar 2008 18:14:32 -0400 Tom Lane [EMAIL PROTECTED] wrote: Perl is required for all MSVC builds, and for all builds from CVS on any platform too, IIRC, so it's a fairly safe bet for any tool you provide. The key phrase in that is

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Peter Eisentraut
Joshua D. Drake wrote: At some point, do we recognize that Perl is installed on every reasonable platform in existence or can be easily? I mean, we already require autoconf/make etc... What is adding Perl in practice? For one thing, a moving target. If we rely on standard Unix tools, we have

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 19 Mar 2008 00:07:09 +0100 Peter Eisentraut [EMAIL PROTECTED] wrote: Joshua D. Drake wrote: At some point, do we recognize that Perl is installed on every reasonable platform in existence or can be easily? I mean, we already require

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-18 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Joshua D. Drake wrote: What is adding Perl in practice? For one thing, a moving target. Well, if we were that afraid of Perl version discrepancies, we shouldn't be using it at all anywhere. My point was just that we should not add a new build tool

Re: [HACKERS] [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

2008-03-17 Thread Peter Eisentraut
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: I think if they can run Gen_fmgrtab, they can get this to work. They can't. They can't run Gen_fmgrtab or they can't get this to work? They can't run Gen_fmgrtab.