Re: [HACKERS] [COMMITTERS] pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

2008-01-15 Thread Tom Lane
I wrote: > * ParameterStatus could be a risk if a function executed during COPY > tried to change one of the above-mentioned parameters. Since COPY OUT > doesn't fire triggers, I think user-defined datatype output functions > would be the only possible candidates for that. Scratch that --- that t

Re: [HACKERS] [COMMITTERS] pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

2008-01-15 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > That's what the docs say, but Tom's patch also adds lines to handle > NOTIFY, which is what prompted the question. I don't believe that code can get executed given the current backend design. I just put it in because the protocol spec says (and always has

Re: [HACKERS] [COMMITTERS] pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

2008-01-15 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Hmm, aren't ParameterStatus messages sent just before Ready For Query? No, they're sent immediately (see ReportGUCOption). I had some ideas in the back of my head about postponing such sends until just before Ready For Query, with the idea of avoiding

Re: [HACKERS] [COMMITTERS] pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

2008-01-15 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Mon, 2008-01-14 at 18:46 +, Tom Lane wrote: >> Fix an ancient oversight in libpq's handling of V3-protocol COPY OUT mode: >> we need to be able to swallow NOTICE messages, and potentially also >> ParameterStatus messages (although the latter would be