Re: [HACKERS] [COMMITTERS] pgsql: Oops, don't forget to rewind the directory before scanning it to

2010-02-22 Thread Andres Freund
On Monday 22 February 2010 04:58:29 Tom Lane wrote: > Fujii Masao writes: > > + Free(xldir); > > > > s/Free/FreeDir ? > > Yeah, that too. I think it's all good now, but please test. At least I havent seen any of the problems pointed out in "fsync fun". > One thing I was wondering was whether

Re: [HACKERS] [COMMITTERS] pgsql: Oops, don't forget to rewind the directory before scanning it to

2010-02-21 Thread Tom Lane
Fujii Masao writes: > + Free(xldir); > s/Free/FreeDir ? Yeah, that too. I think it's all good now, but please test. One thing I was wondering was whether the stat-wrong-file problem could explain the buildfarm failures that we thought were evidence of a portability issue. I was tempted to