Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-07 Thread Claudio Freire
On Sun, Jul 7, 2013 at 4:28 PM, Peter Eisentraut wrote: > On Sun, 2013-07-07 at 02:01 -0300, Claudio Freire wrote: >> You really want to test more than just the str. The patch contains >> casts to int and float, which is something existing PLPython code will >> be doing, so it's good to test it st

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-07 Thread Szymon Guz
On 7 July 2013 21:35, Peter Eisentraut wrote: > On Sun, 2013-07-07 at 17:21 +0200, Szymon Guz wrote: > > I think that these tests are much better, so they should go into > > trunk. > > As for Python 2.5 I think we could modify the code and makefile (with > > additional documentation info) so the

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-07 Thread Peter Eisentraut
On Sun, 2013-07-07 at 17:21 +0200, Szymon Guz wrote: > I think that these tests are much better, so they should go into > trunk. > As for Python 2.5 I think we could modify the code and makefile (with > additional documentation info) so the decimal code wouldn't be > compiled > with python 2.5. I

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-07 Thread Peter Eisentraut
On Sun, 2013-07-07 at 02:01 -0300, Claudio Freire wrote: > You really want to test more than just the str. The patch contains > casts to int and float, which is something existing PLPython code will > be doing, so it's good to test it still can be done with decimal. Let's remember that we are regr

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-06 Thread Szymon Guz
On 6 July 2013 17:58, Claudio Freire wrote: > Look at that: > > return x > $$ LANGUAGE plpythonu; > SELECT * FROM test_type_conversion_numeric(100); > ! INFO: (Decimal('100'), 'Decimal') > CONTEXT: PL/Python function "test_type_conversion_numeric" >test_type_conversion_numeric > -

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-06 Thread Claudio Freire
Look at that: return x $$ LANGUAGE plpythonu; SELECT * FROM test_type_conversion_numeric(100); ! INFO: (Decimal('100'), 'Decimal') CONTEXT: PL/Python function "test_type_conversion_numeric" test_type_conversion_numeric -- --- 219,225 return x $$

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-06 Thread Andrew Dunstan
On 07/06/2013 01:52 AM, Claudio Freire wrote: On Sat, Jul 6, 2013 at 2:39 AM, Tom Lane wrote: Peter Eisentraut writes: PL/Python: Convert numeric to Decimal Assorted buildfarm members don't like this patch. Do you have failure details? This is probably an attempt to operate decimals vs f

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-05 Thread Claudio Freire
On Sat, Jul 6, 2013 at 2:39 AM, Tom Lane wrote: > Peter Eisentraut writes: >> PL/Python: Convert numeric to Decimal > > Assorted buildfarm members don't like this patch. Do you have failure details? This is probably an attempt to operate decimals vs floats. Ie: Decimal('3.0') > 0 works, but D

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-05 Thread Tom Lane
Peter Eisentraut writes: > PL/Python: Convert numeric to Decimal Assorted buildfarm members don't like this patch. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/ma