On mån, 2012-03-26 at 15:53 -0400, Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
On mån, 2012-03-26 at 15:15 -0400, Tom Lane wrote:
I also do not think it does anything for readability for this call
of read_info() to be unexpectedly unlike all the others.
I do not think that
Peter Eisentraut pete...@gmx.net writes:
Remove dead assignment
found by Coverity
init_sequence(seq_relid, elm, seq_rel);
- seq = read_info(elm, seq_rel, buf);
+ read_info(elm, seq_rel, buf);
I have to object to this patch. In the blind service of eliminating
warnings from some tool
On mån, 2012-03-26 at 15:15 -0400, Tom Lane wrote:
init_sequence(seq_relid, elm, seq_rel);
- seq = read_info(elm, seq_rel, buf);
+ read_info(elm, seq_rel, buf);
I have to object to this patch. In the blind service of eliminating
warnings from some tool or other, you will
Peter Eisentraut pete...@gmx.net writes:
On mån, 2012-03-26 at 15:15 -0400, Tom Lane wrote:
I also do not think it does anything for readability for this call
of read_info() to be unexpectedly unlike all the others.
I do not think that it is good code quality to assign something to a
