Re: [HACKERS] [GENERAL] Clang 3.3 Analyzer Results

2013-11-14 Thread Tom Lane
Magnus Hagander writes: > That code was originally "stolen" from psql, and then whacked around a > number of times. The part about looping and passwords, for example, is in > startup.c in psql as well. We probably want to fix it there as well (even > if it doesn't have the same problem, it has th

Re: [HACKERS] [GENERAL] Clang 3.3 Analyzer Results

2013-11-14 Thread Magnus Hagander
On Wednesday, November 13, 2013, Tom Lane wrote: > Kevin Grittner > writes: > > If nobody objects, I'll fix that small memory leak in the > > regression test driver. Hopefully someone more familiar with > > pg_basebackup will fix the double-free (and related problems > > mentioned by Tom) in stre