Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-20 Thread Bruce Momjian
Bruce Momjian wrote: > Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > > > Something is certainly wrong. Did we change sequence table format from > > > 8.3 to 8.4? > > > > 8.3 does not have start_value. > > Looking at an invalidly-migrated sequence's columns: > > regression=> \d ser

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-18 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > Something is certainly wrong. Did we change sequence table format from > > 8.3 to 8.4? > > 8.3 does not have start_value. Looking at an invalidly-migrated sequence's columns: regression=> \d serialtest_f2_foo Sequence "pu

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-16 Thread Bruce Momjian
Peter Eisentraut wrote: > On Thursday 16 July 2009 07:09:22 Bruce Momjian wrote: > > Uh, how is this going to behave in 8.5? Do we still dump sequences, and > > if so, aren't we heading down the road of dumping stuff only because a > > previous release needed it? > > Which leads me to a related q

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-16 Thread Tom Lane
Peter Eisentraut writes: > Which leads me to a related question: Do you plan to maintain one > version of pg_migrator that can upgrade any version to any other > version (within reason), or will there be separate binaries, say > pg_migrator-8.4 and pg_migrator-8.5, that each can only upgrade from

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-16 Thread Bruce Momjian
Dimitri Fontaine wrote: > Tom Lane writes: > > > Bruce Momjian writes: > >> A larger question is what do we do with pg_migrator now. I am > >> embarrassed I didn't find these errors before, but now that they are > >> known, and will probably need an 8.4.1 to fix, should I remove the > >> pg_mig

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-16 Thread Peter Eisentraut
On Thursday 16 July 2009 07:09:22 Bruce Momjian wrote: > Uh, how is this going to behave in 8.5? Do we still dump sequences, and > if so, aren't we heading down the road of dumping stuff only because a > previous release needed it? Which leads me to a related question: Do you plan to maintain on

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-16 Thread Dimitri Fontaine
Tom Lane writes: > Bruce Momjian writes: >> A larger question is what do we do with pg_migrator now. I am >> embarrassed I didn't find these errors before, but now that they are >> known, and will probably need an 8.4.1 to fix, should I remove the >> pg_migrator 8.4 source code from pgfoundry?

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> The most effective solution might be to revert the change in pg_migrator > >> and instead have pg_dump interpret --binary-upgrade --schema-only to > >> include the data for sequences. It seems ugly as sin though :-( > > > Uh, how i

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Tom Lane
Bruce Momjian writes: > A larger question is what do we do with pg_migrator now. I am > embarrassed I didn't find these errors before, but now that they are > known, and will probably need an 8.4.1 to fix, should I remove the > pg_migrator 8.4 source code from pgfoundry? Well, we'd still like pe

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> The most effective solution might be to revert the change in pg_migrator >> and instead have pg_dump interpret --binary-upgrade --schema-only to >> include the data for sequences. It seems ugly as sin though :-( > Uh, how is this going to behave in 8.5?

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Bruce Momjian
Tom Lane wrote: > Zdenek Kotala writes: > > I think you don't need transfer sequence table, because pg_dump should > > create DDL command (CREATE SEQUENCE) which should create new nice > > sequence relation. > > Yeah, but pg_dump is doing a schema-only dump so it doesn't transfer the > current

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Bruce Momjian
Bruce Momjian wrote: > > A larger question is what do we do with pg_migrator now. I am > embarrassed I didn't find these errors before, but now that they are > known, and will probably need an 8.4.1 to fix, should I remove the > pg_migrator 8.4 source code from pgfoundry? FYI, I am at Enterprise

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Bruce Momjian
A larger question is what do we do with pg_migrator now. I am embarrassed I didn't find these errors before, but now that they are known, and will probably need an 8.4.1 to fix, should I remove the pg_migrator 8.4 source code from pgfoundry? --

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> The most effective solution might be to revert the change in pg_migrator > >> and instead have pg_dump interpret --binary-upgrade --schema-only to > >> include the data for sequences. It seems ugly as sin though :-( > > > It seems

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> The most effective solution might be to revert the change in pg_migrator >> and instead have pg_dump interpret --binary-upgrade --schema-only to >> include the data for sequences. It seems ugly as sin though :-( > It seems cleaner to have a pg_dump --d

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Alvaro Herrera
Tom Lane wrote: > Zdenek Kotala writes: > > I think you don't need transfer sequence table, because pg_dump should > > create DDL command (CREATE SEQUENCE) which should create new nice > > sequence relation. > > Yeah, but pg_dump is doing a schema-only dump so it doesn't transfer the > current

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Tom Lane
Zdenek Kotala writes: > I think you don't need transfer sequence table, because pg_dump should > create DDL command (CREATE SEQUENCE) which should create new nice > sequence relation. Yeah, but pg_dump is doing a schema-only dump so it doesn't transfer the current state of the sequence. The mo

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-15 Thread Zdenek Kotala
Dne 14.07.09 04:37, Bruce Momjian napsal(a): Tom Lane wrote: Bruce Momjian writes: Tilmann Singer wrote: However, all of the sequences were at the initial values and not bumped up to the last used value as I would have expected. The first nextval call on any sequence in the mig

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-14 Thread Alvaro Herrera
Bruce Momjian wrote: > Something is certainly wrong. Did we change sequence table format from > 8.3 to 8.4? 8.3 does not have start_value. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers ma

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-14 Thread Tom Lane
Bruce Momjian writes: > Did we change sequence table format from > 8.3 to 8.4? Oh, yes we did: we added a start_value column. So this is going to take more work than that :-( regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To mak

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-14 Thread Bruce Momjian
bruce wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Tilmann Singer wrote: > > >> However, all of the sequences were at the initial values and not > > >> bumped up to the last used value as I would have expected. The first > > >> nextval call on any sequence in the migrated 8.4 database

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tilmann Singer wrote: > >> However, all of the sequences were at the initial values and not > >> bumped up to the last used value as I would have expected. The first > >> nextval call on any sequence in the migrated 8.4 database always > >> returned 1. >

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-13 Thread Tom Lane
Bruce Momjian writes: > Tilmann Singer wrote: >> However, all of the sequences were at the initial values and not >> bumped up to the last used value as I would have expected. The first >> nextval call on any sequence in the migrated 8.4 database always >> returned 1. > Wow, that is also surprisi

Re: [HACKERS] [GENERAL] pg_migrator not setting values of sequences?

2009-07-13 Thread Bruce Momjian
Tilmann Singer wrote: > I tried the latest pg_migrator > (http://pgfoundry.org/frs/download.php/2291/pg_migrator-8.4.tgz) to > migrate a database from an 8.3.7 to an 8.4.0 cluster. It finished with > a success message, and the schema and all tables seem to have been > migrated correctly. > > Howev