Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-10-18 Thread Peter Eisentraut
On Thu, 2013-10-17 at 13:49 +1100, James Sewell wrote: > The search+bind mode issue is one of documentation location, I have > fixed it by moving the section to the applied to both list. As the > patch is to do with post-auth response this is correct. > Makes sense. > As far as the issue when s

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-10-16 Thread James Sewell
Hey All, I had missed these emails, sorry. The search+bind mode issue is one of documentation location, I have fixed it by moving the section to the applied to both list. As the patch is to do with post-auth response this is correct. As far as the issue when something other than 0 or 1 is set I

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-09-18 Thread Peter Eisentraut
On 7/8/13 9:33 PM, James Sewell wrote: > New patch attached. I've moved from using a boolean to an enum trivalue. When ldapreferrals is set to something other than "0" or "1" exactly, it just ignores the option. That's not good, I think. It should probably be an error. -- Sent via pgsql-hack

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-09-16 Thread Peter Eisentraut
On Tue, 2013-07-09 at 11:33 +1000, James Sewell wrote: > New patch attached. I've moved from using a boolean to an enum > trivalue. You have updated the documentation to say that the ldareferrals option only applies in search+bind mode. But looking over the code I think it applies in both modes.

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-09 Thread Magnus Hagander
On Tue, Jul 9, 2013 at 3:33 AM, James Sewell wrote: > Hey, > > New patch attached. I've moved from using a boolean to an enum trivalue. > > Let me know what you think. > > Please add your patch at https://commitfest.postgresql.org/action/commitfest_view?id=19 so it's not missed in the next commitf

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-08 Thread James Sewell
Hey, New patch attached. I've moved from using a boolean to an enum trivalue. Let me know what you think. Cheers, James James Sewell PostgreSQL Team Lead / Solutions Architect _ [image: http://www.lisasoft.com/sites/lisasoft/files/u1/2013hieghtslogan_0.png]

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-04 Thread Magnus Hagander
On Thu, Jul 4, 2013 at 2:30 AM, James Sewell wrote: > Heya, > > I see what you are saying, the problem as I see it is that the action we > are taking here is "disable chasing ldap referrals". If the name is > ldapreferrals and we use a boolean then setting it to 1 reads in a counter > intuitive m

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-03 Thread James Sewell
Heya, I see what you are saying, the problem as I see it is that the action we are taking here is "disable chasing ldap referrals". If the name is ldapreferrals and we use a boolean then setting it to 1 reads in a counter intuitive manner: "set ldapreferals=true to disable chasing LDAP referra

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-03 Thread Magnus Hagander
On Wed, Jul 3, 2013 at 3:04 AM, James Sewell wrote: > Hey Peter, > > You are correct, it is the same as the referrals option in pam_ldap. It's > also the -C (sometimes -R - it seems ldapsearch options are pretty > non-standard) option in ldapsearch. > > As far as I'm aware you can't pass this in

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-02 Thread James Sewell
Hey Peter, You are correct, it is the same as the referrals option in pam_ldap. It's also the -C (sometimes -R - it seems ldapsearch options are pretty non-standard) option in ldapsearch. As far as I'm aware you can't pass this in an LDAP URL, primarily because this never gets sent to the LDAP s

Re: [HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-02 Thread Peter Eisentraut
On 7/2/13 12:20 AM, James Sewell wrote: > Hey All, > > This patch request grew from this post (of mine) to pgsql-general: > > http://www.postgresql.org/message-id/cabuevezouae-g1_oejagujjmem675dnystwybp4d_wz6om+...@mail.gmail.com > > The patch adds another available LDAP option (ldapnochaseref)

[HACKERS] [PATCH] Add an ldapoption to disable chasing LDAP referrals

2013-07-01 Thread James Sewell
Hey All, This patch request grew from this post (of mine) to pgsql-general: http://www.postgresql.org/message-id/cabuevezouae-g1_oejagujjmem675dnystwybp4d_wz6om+...@mail.gmail.com The patch adds another available LDAP option (ldapnochaseref) for search+bind mode in the pg_hba.conf fil. If set to