Re: [HACKERS] [PATCH] Cleanup: use heap_open/heap_close consistently

2012-02-27 Thread Robert Haas
On Mon, Feb 27, 2012 at 11:59 AM, Tom Lane wrote: > Robert Haas writes: >> I'm almost inclined to think that >> we should be trying to get rid of heap_open() altogether; there are >> already plenty of places that assume that opening the relation is as >> good as opening the heap, so I don't think

Re: [HACKERS] [PATCH] Cleanup: use heap_open/heap_close consistently

2012-02-27 Thread Tom Lane
Robert Haas writes: > I'm almost inclined to think that > we should be trying to get rid of heap_open() altogether; there are > already plenty of places that assume that opening the relation is as > good as opening the heap, so I don't think there'd be any real loss of > abstraction. Or, perhaps,

Re: [HACKERS] [PATCH] Cleanup: use heap_open/heap_close consistently

2012-02-27 Thread Robert Haas
On Mon, Feb 27, 2012 at 5:45 AM, Marti Raudsepp wrote: > Here's a tiny cleanup: currently get_tables_to_cluster uses > heap_open() to open the relation, but then closes it with > relation_close(). Currently relation_close=heap_close, but it seems > like good idea to be consistent -- in case these

[HACKERS] [PATCH] Cleanup: use heap_open/heap_close consistently

2012-02-27 Thread Marti Raudsepp
Hi, Here's a tiny cleanup: currently get_tables_to_cluster uses heap_open() to open the relation, but then closes it with relation_close(). Currently relation_close=heap_close, but it seems like good idea to be consistent -- in case these functions need to diverge in the future. Regards, Marti d