Jonah H. Harris wrote:
On Wed, Jan 21, 2009 at 2:02 PM, Robert Haas wrote:
Was there a reason that this cleanup patch wasn't applied?
1. It was submitted after the deadline for CommitFest:November.
Well, it's just comment changes...
Oh, didn't realize that. That's what I get for replying wi
On Wed, Jan 21, 2009 at 2:02 PM, Robert Haas wrote:
> >>> Was there a reason that this cleanup patch wasn't applied?
> >>
> >> 1. It was submitted after the deadline for CommitFest:November.
> >
> > Well, it's just comment changes...
>
> Oh, didn't realize that. That's what I get for replying wi
>>> Was there a reason that this cleanup patch wasn't applied?
>>
>> 1. It was submitted after the deadline for CommitFest:November.
>
> Well, it's just comment changes...
Oh, didn't realize that. That's what I get for replying without
reading the patch...
...Robert
--
Sent via pgsql-hackers m
Alvaro Herrera escribió:
> The only possible gripe I have is that the grammar in the second hunk
> seems strange or broken, but maybe it's just that I don't know the
> language enough.
Oh, it makes sense if you consider "states" as a noun rather than a verb.
--
Alvaro Herrera
Heikki Linnakangas escribió:
> (I haven't checked whether the comment changes are a good idea. But they
> probably are..)
The original comments are broken, the new ones seem good. I think this
patch should just be applied. The only possible gripe I have is that
the grammar in the second hunk
Robert Haas wrote:
On Wed, Jan 21, 2009 at 6:17 AM, Jonah H. Harris wrote:
On Thu, Nov 6, 2008 at 12:03 AM, Jonah H. Harris
wrote:
As I wasn't sure whether anyone agrees with my distaste for
repurposing tgenabled as mentioned above, I have attached is a patch
which minimally corrects the func
On Wed, Jan 21, 2009 at 6:17 AM, Jonah H. Harris wrote:
> On Thu, Nov 6, 2008 at 12:03 AM, Jonah H. Harris
> wrote:
>>
>> As I wasn't sure whether anyone agrees with my distaste for
>> repurposing tgenabled as mentioned above, I have attached is a patch
>> which minimally corrects the function co
On Thu, Nov 6, 2008 at 12:03 AM, Jonah H. Harris wrote:
> As I wasn't sure whether anyone agrees with my distaste for
> repurposing tgenabled as mentioned above, I have attached is a patch
> which minimally corrects the function comment for EnableDisableTrigger
> where fires_when is concerned.
W
On Thu, Nov 6, 2008 at 10:08 AM, Tom Lane <[EMAIL PROTECTED]> wrote:
> I have no objection to cleaning up the backend internals, but system
> catalog definitions are client-visible. I don't think we should thrash
> the catalog definitions for minor aesthetic improvements. Since 8.3 is
> already o
"Jonah H. Harris" <[EMAIL PROTECTED]> writes:
> On Thu, Nov 6, 2008 at 9:01 AM, Tom Lane <[EMAIL PROTECTED]> wrote:
>> It would have been useful to make this criticism before 8.3 was
>> released. I don't think it's reasonable to change it now.
> Well, I didn't have time to review code back in the
On Thu, Nov 6, 2008 at 9:01 AM, Tom Lane <[EMAIL PROTECTED]> wrote:
> It would have been useful to make this criticism before 8.3 was
> released. I don't think it's reasonable to change it now.
Well, I didn't have time to review code back in the 8.3 days, and ugly
is ugly regardless of when it wa
"Jonah H. Harris" <[EMAIL PROTECTED]> writes:
> While working on the join elimination patch, I was going through the
> trigger code and found quite a bit of nastiness in regard to naming
> and variable repurposing related to the addition of replication roles
> in 8.3. The most obvious issue is tha
While working on the join elimination patch, I was going through the
trigger code and found quite a bit of nastiness in regard to naming
and variable repurposing related to the addition of replication roles
in 8.3. The most obvious issue is that tgenabled was switched from a
bool to char to suppor
13 matches
Mail list logo
