On Fri, Oct 21, 2011 at 4:37 PM, Tom Lane wrote:
> Robert Haas writes:
>> I have committed this version. I'm expecting Tom to try to find a
>> scenario in which it's unfixably broken, so we'll see how that turns
>> out; but there seems to be significant support for this feature and
>> I'm hopefu
Robert Haas writes:
> I have committed this version. I'm expecting Tom to try to find a
> scenario in which it's unfixably broken, so we'll see how that turns
> out; but there seems to be significant support for this feature and
> I'm hopeful that this will pass (or can be made to pass) muster.
On Fri, Oct 21, 2011 at 11:45 AM, Marti Raudsepp wrote:
>> It's almost making me cry
>> thinking about how much time this would have saved me
>
> Thanks for your review and the generous words. :)
I have committed this version. I'm expecting Tom to try to find a
scenario in which it's unfixably b
Hi, here's version 4 of the patch.
On Wed, Oct 19, 2011 at 19:34, Robert Haas wrote:
> I think it would be safer to write this so that
> pgstat_get_crashed_backend_activity writes its answer into a
> statically allocated buffer and returns a pointer to that buffer,
> rather than using palloc. I t
On Thu, Oct 6, 2011 at 10:15 PM, gabrielle wrote:
> On Wed, Oct 5, 2011 at 5:14 PM, Marti Raudsepp wrote:
>> I think you intended to use the "Waiting on Author" status -- that
>> leaves the commitfest entry open. I will re-open the commitfest entry
>> myself, I hope that's OK.
>
> No worries, and
On Wed, Oct 5, 2011 at 5:14 PM, Marti Raudsepp wrote:
> I think you intended to use the "Waiting on Author" status -- that
> leaves the commitfest entry open. I will re-open the commitfest entry
> myself, I hope that's OK.
No worries, and yeah, I picked the wrong checkbox. :)
> Here is version 3
Hi,
My apologies for the last grumpy message I wrote; I sent it out of
surprise that my patch was marked "closed" on the current commitfest.
I hope I haven't discouraged you from reviewing this updated version.
I think you intended to use the "Waiting on Author" status -- that
leaves the commitfe
