Re: [HACKERS] [PATCH] Make skipped sort explicit in EXPLAIN ANALYZE

2012-05-25 Thread Peter Geoghegan
On 25 May 2012 15:19, Marti Raudsepp wrote: > I understand where you're coming from, but personally I think the > current output is more confusing: "Gee Postgres is stupid, it's > sorting when there's nothing to sort!" > > But let's wait for a third opinion. I agree with Tom. The idea that you "s

Re: [HACKERS] [PATCH] Make skipped sort explicit in EXPLAIN ANALYZE

2012-05-25 Thread Marti Raudsepp
On Fri, May 25, 2012 at 4:49 PM, Tom Lane wrote: > I'm not convinced this is an improvement; it's just one more value > to confuse people with. I understand where you're coming from, but personally I think the current output is more confusing: "Gee Postgres is stupid, it's sorting when there's no

Re: [HACKERS] [PATCH] Make skipped sort explicit in EXPLAIN ANALYZE

2012-05-25 Thread Tom Lane
Marti Raudsepp writes: > This is just a small clarity improvement. tuplesort_performsort() > skips sorting entirely when the result set has 0 or 1 tuples, but > EXPLAIN still says it's using "quicksort". The patch changes that to > "skipped" I'm not convinced this is an improvement; it's just one

[HACKERS] [PATCH] Make skipped sort explicit in EXPLAIN ANALYZE

2012-05-25 Thread Marti Raudsepp
Hi, This is just a small clarity improvement. tuplesort_performsort() skips sorting entirely when the result set has 0 or 1 tuples, but EXPLAIN still says it's using "quicksort". The patch changes that to "skipped" For example: db=# explain analyze select * from now() order by 1; Sort (cost=0.