Re: [HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Tom Lane
Martin Mai writes: > Tom Lane wrote: >> I was considering changing "the files they are used to build" >> to "the files that these tools are used to build". I think the >> main problem is just misunderstanding which things "they" means, >> and that

Re: [HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Martin Mai
+1 Just after writing my last message it clicked and I understood that the current wording is correct. Your suggestion makes it clearer, though. Tom Lane wrote: > I was considering changing "the files they are used to build" > to "the files that these tools are used to

Re: [HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Martin Mai
Oh, now I think I got it... The tools are not required to build from distribution tarball, because the files that are normally build by the tools, are already included in the tarball. Realizing that, I agree with you that the current wording is correct and my second suggestion would be as wrong

Re: [HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Tom Lane
Pantelis Theodosiou writes: > On Sun, Jul 9, 2017 at 6:27 PM, Martin Mai wrote: >> Since "they" means the tools, would changing >> ... the files they are used to build are included in the tarball. >> to >> ... the files they use to build [it] are

Re: [HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Pantelis Theodosiou
On Sun, Jul 9, 2017 at 6:27 PM, Martin Mai wrote: > Hello Tom, > > thanks for the clarification. The sentence felt a little bumpy to me, > but I am native German speaker, so maybe it is just me then. > > Since "they" means the tools, would changing > ... the files they

Re: [HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Martin Mai
Hello Tom, thanks for the clarification. The sentence felt a little bumpy to me, but I am native German speaker, so maybe it is just me then. Since "they" means the tools, would changing ... the files they are used to build are included in the tarball. to ... the files they use to build [it] are

Re: [HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Tom Lane
Martin Mai writes: > I found a typo while reading the source repository documentation: > https://www.postgresql.org/docs/devel/static/sourcerepo.html Hm, I dunno, I like the existing wording better than yours. I agree that it's a bit unclear that the antecedent of

[HACKERS] [PATCH] Minor typo in the source repository documentation

2017-07-09 Thread Martin Mai
Hello, I found a typo while reading the source repository documentation: https://www.postgresql.org/docs/devel/static/sourcerepo.html Attached patch fixes it. Cheers Martin Mai From 41febee1363aa62babd2b88fbb4ad1a2e8023f13 Mon Sep 17 00:00:00 2001 From: Martin Mai