Re: [HACKERS] [PATCH] Report exit code from external recovery commands properly

2013-12-02 Thread Peter Geoghegan
On Mon, Dec 2, 2013 at 6:23 PM, Peter Eisentraut wrote: > which I think addresses your point. Fair enough. Marked "ready for committer". -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/m

Re: [HACKERS] [PATCH] Report exit code from external recovery commands properly

2013-12-02 Thread Peter Eisentraut
On Sat, 2013-11-30 at 15:56 -0800, Peter Geoghegan wrote: > On Sun, Nov 24, 2013 at 5:11 AM, Peter Eisentraut wrote: > > How about this? > > Hmm. You say: > > +If the command returns a nonzero exit status then a warning log > +message will be written. An exception is that if the

Re: [HACKERS] [PATCH] Report exit code from external recovery commands properly

2013-11-30 Thread Peter Geoghegan
On Sun, Nov 24, 2013 at 5:11 AM, Peter Eisentraut wrote: > How about this? Hmm. You say: +If the command returns a nonzero exit status then a warning log +message will be written. An exception is that if the command was +terminated by a signal or an error by the shell (s

Re: [HACKERS] [PATCH] Report exit code from external recovery commands properly

2013-11-24 Thread Peter Eisentraut
On Wed, 2013-11-13 at 19:14 -0800, Peter Geoghegan wrote: > I think this is a very good idea, but you should go a bit further: > document the special relationship restore_command has to special > return codes. How about this? diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml index

Re: [HACKERS] [PATCH] Report exit code from external recovery commands properly

2013-11-13 Thread Peter Geoghegan
On Wed, Nov 13, 2013 at 3:42 AM, Peter Eisentraut wrote: > When an external recovery command such as restore_command or > archive_cleanup_command fails, it just reports "return code 34567" or > something, but we have facilities to do decode this properly, so use > them. I think this is a very goo

[HACKERS] [PATCH] Report exit code from external recovery commands properly

2013-11-13 Thread Peter Eisentraut
When an external recovery command such as restore_command or archive_cleanup_command fails, it just reports "return code 34567" or something, but we have facilities to do decode this properly, so use them. >From 8aa3cf503fe1c1f41a2a833c008f4273c22a86c9 Mon Sep 17 00:00:00 2001 From: Peter Eisentra