Re: [HACKERS] [PATCH 5/6] psql: print_aligned_text uses table formatting

2009-08-23 Thread Alvaro Herrera
Roger Leigh wrote: > On Sun, Aug 23, 2009 at 11:47:02AM -0400, Alvaro Herrera wrote: > > Wouldn't it be better to do a single fprintf call here instead of > > fputc + fputs? > > It's certainly possible to change it; the above might be slightly more > efficient than a call to fprintf since you ski

Re: [HACKERS] [PATCH 5/6] psql: print_aligned_text uses table formatting

2009-08-23 Thread Alvaro Herrera
Roger Leigh wrote: > Convert print_aligned_text, and its helper function, to use > table formatting in place of hardcoded ASCII characters. > @@ -841,7 +856,10 @@ print_aligned_text(const printTableContent *cont, const > printTextFormat *format, > > /* left border */ >

Re: [HACKERS] [PATCH 5/6] psql: print_aligned_text uses table formatting

2009-08-23 Thread Roger Leigh
On Sun, Aug 23, 2009 at 11:47:02AM -0400, Alvaro Herrera wrote: > Roger Leigh wrote: > > Convert print_aligned_text, and its helper function, to use > > table formatting in place of hardcoded ASCII characters. > > > @@ -841,7 +856,10 @@ print_aligned_text(const printTableContent *cont, > > const

[HACKERS] [PATCH 5/6] psql: print_aligned_text uses table formatting

2009-08-22 Thread Roger Leigh
Convert print_aligned_text, and its helper function, to use table formatting in place of hardcoded ASCII characters. Signed-off-by: Roger Leigh --- src/bin/psql/print.c | 50 +- 1 files changed, 37 insertions(+), 13 deletions(-) diff --git a/src