Magnus Hagander [EMAIL PROTECTED] writes:
Attached patch removes a couple of extern definitions from adminpack,
replacing some of them with a #include. (Cam eup with this because we
got a duplicate definition of DataDir when building with Visual C++).
That isn't going to work unless we put
Attached patch removes a couple of extern definitions from
adminpack,
replacing some of them with a #include. (Cam eup with this
because we
got a duplicate definition of DataDir when building with
Visual C++).
That isn't going to work unless we put DLLIMPORT into the
main
Magnus Hagander [EMAIL PROTECTED] writes:
The reason for redeclaring these in the contrib files is to
get DLLIMPORT onto them...
Interedting - it builds on MSVC without it :-O
Anyway. That certainly explains why MSVC is complaining - it's getting
completely different definitions of these
The reason for redeclaring these in the contrib files is to get
DLLIMPORT onto them...
Interedting - it builds on MSVC without it :-O
Anyway. That certainly explains why MSVC is complaining -
it's getting
completely different definitions of these variables from the header
and
Magnus Hagander [EMAIL PROTECTED] writes:
The same redeclaration technique is being used elsewhere
(pg_buffercache and pg_freespacemap it looks like). Aren't
you getting warnings there too?
I am - I just started working on getting those done as well.
OK, I guess we gotta play them all
Magnus Hagander [EMAIL PROTECTED] writes:
Attached patch removes a couple of extern definitions from adminpack,
replacing some of them with a #include.
I've now removed all the local DLLIMPORT-redeclarations I could find
in favor of marking the relevant variables in the main header files.
Attached patch removes a couple of extern definitions from
adminpack,
replacing some of them with a #include.
I've now removed all the local DLLIMPORT-redeclarations I
could find in favor of marking the relevant variables in the
main header files.
Thanks. All affected projects build
