On Tue, May 30, 2006 at 06:20:33PM -0400, Tom Lane wrote:
Now that the magic-block patch is in, we need to revisit this bit of the
discussion. I'm for making lack of a magic block an ERROR immediately.
I don't see the point of waiting; in fact, if we wait till freeze we'll
just make the
On Sun, May 07, 2006 at 08:21:43PM -0400, Tom Lane wrote:
I'm pretty sure we had agreed that magic blocks should be
required;
otherwise this check will accomplish little.
Sure, I just didn't want to break every module in one
weekend. I was
thinking of adding it with LOG level
Magnus Hagander wrote:
On Sun, May 07, 2006 at 08:21:43PM -0400, Tom Lane wrote:
I'm pretty sure we had agreed that magic blocks should be
required;
otherwise this check will accomplish little.
Sure, I just didn't want to break every module in one
weekend. I was
thinking
Martijn van Oosterhout kleptog@svana.org writes:
If you like I can send a patch that adds it to all of contrib and some
of the other places required so that make check passes...
Think I got them all already:
http://archives.postgresql.org/pgsql-committers/2006-05/msg00384.php
but if you see any
Martijn van Oosterhout kleptog@svana.org writes:
On Sun, May 07, 2006 at 08:21:43PM -0400, Tom Lane wrote:
I'm pretty sure we had agreed that magic blocks should be required;
otherwise this check will accomplish little.
Sure, I just didn't want to break every module in one weekend. I was
