Re: [HACKERS] [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee

2007-05-28 Thread Simon Riggs
On Fri, 2007-04-13 at 16:09 +0100, Simon Riggs wrote: > I'll make the agreed changes by next Wed/Thurs. I am actively working on this now, after some delays because of other calls on my time. The suggested changes have needed more rework than I estimated, touching most lines of the patch, but I d

Re: [HACKERS] [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee

2007-05-15 Thread Bruce Momjian
Simon Riggs wrote: > > > 3. Should the WALWriter also do the wal_buffers half-full write at the > > > start of XLogInsert() ? > > > > That should go away entirely; to me the main point of the separate > > wal-writer process is to take over responsibility for not letting too > > many dirty wal buff

Re: [HACKERS] [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee

2007-04-26 Thread Bruce Momjian
Simon Riggs wrote: > > That should go away entirely; to me the main point of the separate > > wal-writer process is to take over responsibility for not letting too > > many dirty wal buffers accumulate. > > Yes > > > I'll make the agreed changes by next Wed/Thurs. I have seen no patch yet with

Re: [HACKERS] [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee

2007-04-13 Thread Simon Riggs
On Thu, 2007-04-12 at 15:56 -0400, Tom Lane wrote: > "Simon Riggs" <[EMAIL PROTECTED]> writes: > > transaction_guarantee.v11.patch Thanks for the review. > I can't help feeling that this is enormously overcomplicated. I agree with all but one of your comments, see below. > The "DFC" in partic