Re: [HACKERS] [PATCHES] Use of backslash in tsearch2

2006-09-02 Thread Bruce Momjian
Thanks. Yes, it is need for two reasons. In 8.2 you can set standard_conforming_strings to on, meaning \' is really treated as \ and ', and because some encodings now can't support \' for security reasons, though I don't think tsearch2 supports those multibyte encodings. Anyway, applied to 8.2

Re: [HACKERS] [PATCHES] Use of backslash in tsearch2

2006-08-23 Thread Teodor Sigaev
Patch isn't full, simple test (values are took from regression.diffs): and try dump table and restore: ERROR: syntax error CONTEXT: COPY tt, line 5, column tq: '1 ''2' Attached cumulative patch fixes problem, but I have some doubts, is it really needed? -- Teodor Sigaev

Re: [HACKERS] [PATCHES] Use of backslash in tsearch2

2006-08-22 Thread Teodor Sigaev
Teodor, are the new attached regression results correct? If so, I will apply the patch and update the expected file. Patch isn't full, simple test (values are took from regression.diffs): # create table tt (tv tsvector, tq tsquery); # insert into tt values (E'''1 \\''2''', NULL); # insert into

Re: [HACKERS] [PATCHES] Use of backslash in tsearch2

2006-08-21 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: As part of the move to support standard-conforming strings and treat backslash literally, I reviewed the tsearch2 code and found two place that seemed to use \' rather than '', and generated the attached patch. I thought we had decided that that code

Re: [HACKERS] [PATCHES] Use of backslash in tsearch2

2006-08-21 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: As part of the move to support standard-conforming strings and treat backslash literally, I reviewed the tsearch2 code and found two place that seemed to use \' rather than '', and generated the attached patch. I thought we had