Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-06 Thread Hannu Krosing
Andrew Dunstan kirjutas L, 06.09.2003 kell 16:14: > Peter Eisentraut wrote: > > >Tom Lane writes: > > > > > > > >>There are good security arguments not to have it in the default install, > >>no? > >> > >> > > > >I think last time the only reason we saw was that dump restoring would be > >dif

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-06 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > I did see a reference in the archives to a problem with heavy recursion > as a possible security hole. I guess my answer to that would be that if > you are worried about it you should drop the language, but I don't see > this alone as a reason not to

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-06 Thread Andrew Dunstan
Peter Eisentraut wrote: Tom Lane writes: There are good security arguments not to have it in the default install, no? I think last time the only reason we saw was that dump restoring would be difficult. I don't see any security reasons. That could be overcome by doing a 'drop language'

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Rod Taylor
On Fri, 2003-09-05 at 16:54, Bruce Momjian wrote: > Peter Eisentraut wrote: > > Bruce Momjian writes: > > > > > I don't mind the maintenance. I just want people to stop getting stuck > > > creating plpsql functions. > > > > Then put plpgsql in the default installation. > > Fine with me. I thou

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Larry Rosenman
--On Friday, September 05, 2003 22:37:09 +0200 Peter Eisentraut <[EMAIL PROTECTED]> wrote: Bruce Momjian writes: I don't mind the maintenance. I just want people to stop getting stuck creating plpsql functions. Then put plpgsql in the default installation. Why don't we do that now? It would

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Peter Eisentraut
Tom Lane writes: > There are good security arguments not to have it in the default install, > no? I think last time the only reason we saw was that dump restoring would be difficult. I don't see any security reasons. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > I don't mind the maintenance. I just want people to stop getting stuck > > creating plpsql functions. > > Then put plpgsql in the default installation. Fine with me. I thought others didn't want it. -- Bruce Momjian

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Peter Eisentraut wrote: > >> Bruce Momjian writes: > >>> I don't mind the maintenance. I just want people to stop getting stuck > >>> creating plpsql functions. > >> > >> Then put plpgsql in the default installation. > > > Fine with

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> Bruce Momjian writes: >>> I don't mind the maintenance. I just want people to stop getting stuck >>> creating plpsql functions. >> >> Then put plpgsql in the default installation. > Fine with me. I thought others didn't want

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Peter Eisentraut
Bruce Momjian writes: > I don't mind the maintenance. I just want people to stop getting stuck > creating plpsql functions. Then put plpgsql in the default installation. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 9: th

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >> BTW, duplicating the ereport is no fun. I'd suggest the coding style >> used in some other places, with errhint called in a conditional >> expression: > Why does the ': 0' work? I didn't figure that would work, but it does. The return values of the e

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > >> We could answer my objection about the hint popping out on misspelled > >> language names if the code were to arrange to put out the hint only when > >> the language name is one of "plpgsql", "pltcl", "pltclu", etc. This > >> would h

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >> We could answer my objection about the hint popping out on misspelled >> language names if the code were to arrange to put out the hint only when >> the language name is one of "plpgsql", "pltcl", "pltclu", etc. This >> would have to use a hard-coded li

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Bruce Momjian
Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > Bruce Momjian wrote: > >>> HINT: Perhaps you need to use 'createlang' to load the language into > >>> the database, or you mistyped the language name. > > > Why not list out the languages we *do* know about, and tell them it's > >

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Rod Taylor
On Fri, 2003-09-05 at 09:52, Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > Bruce Momjian wrote: > >>> HINT: Perhaps you need to use 'createlang' to load the language into > >>> the database, or you mistyped the language name. > > > Why not list out the languages we *do* know ab

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Bruce Momjian wrote: >>> HINT: Perhaps you need to use 'createlang' to load the language into >>> the database, or you mistyped the language name. > Why not list out the languages we *do* know about, and tell them it's > not in the list? Or is that to

Re: [HACKERS] [PATCHES] Warning for missing createlang

2003-09-05 Thread Andrew Dunstan
Bruce Momjian wrote: Bruce Momjian wrote: I have written a patch to issue an hint if someone tries to create a function in a language that isn't loaded into the database: test=> CREATE FUNCTION xx() RETURNS INT AS ' test'> select 1' test-> LANGUAGE 'plpgsql'; E