Re: [HACKERS] [PATCHES] mcxt.c

2003-09-09 Thread Andrew Dunstan
Alvaro Herrera Munoz wrote: On Tue, Sep 09, 2003 at 04:53:06PM +0200, Gaetano Mendola wrote: "Andrew Dunstan" <[EMAIL PROTECTED]> wrote: The particular assertion that was proposed doesn't strike me as terribly useful - It should be checked at the point of call rather than inside pstrdup,

Re: [HACKERS] [PATCHES] mcxt.c

2003-09-09 Thread Alvaro Herrera Munoz
On Tue, Sep 09, 2003 at 04:53:06PM +0200, Gaetano Mendola wrote: > "Andrew Dunstan" <[EMAIL PROTECTED]> wrote: > > The particular assertion that was proposed doesn't strike me as terribly > > useful - It should be checked at the point of call rather than inside > > pstrdup, I should have thought.

Re: [HACKERS] [PATCHES] mcxt.c

2003-09-09 Thread Gaetano Mendola
"Andrew Dunstan" <[EMAIL PROTECTED]> wrote: > The particular assertion that was proposed doesn't strike me as terribly > useful - It should be checked at the point of call rather than inside > pstrdup, I should have thought. Are you going to trust the client of that function ? Here the question

Re: [HACKERS] [PATCHES] mcxt.c

2003-09-09 Thread Andrew Dunstan
The particular assertion that was proposed doesn't strike me as terribly useful - It should be checked at the point of call rather than inside pstrdup, I should have thought. Of course, that would make for lots of code bloat ... cases like this are when gdb is your friend. cheers andrew Tom

Re: [HACKERS] [PATCHES] mcxt.c

2003-09-08 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > Neil Conway <[EMAIL PROTECTED]> writes: >> I think the percentage of deployments that enable assertions (which >> causes a runtime performance hit) but NOT debugging info (which does >> not) is pretty small. > How big a penalty is it? If it's small, or if i

Re: [HACKERS] [PATCHES] mcxt.c

2003-09-08 Thread Greg Stark
Neil Conway <[EMAIL PROTECTED]> writes: > I think the percentage of deployments that enable assertions (which > causes a runtime performance hit) but NOT debugging info (which does > not) is pretty small. How big a penalty is it? If it's small, or if it could be made small by making a few assert

Re: [HACKERS] [PATCHES] mcxt.c

2003-09-08 Thread Neil Conway
On Mon, 2003-09-08 at 11:09, Gaetano Mendola wrote: > "Tom Lane" <[EMAIL PROTECTED]> wrote: > > I see no value at all in an assert. The code will dump core just fine > > with or without an assert ... > > Right but an assert can display information about the file and line number > without debug t