Re: [HACKERS] [Review] fix dblink security hole

2008-09-16 Thread Ibrar Ahmed
> > > > I have attached a patch just for the quick thought. Otherwise there is no > > issue with patch. > > This is no good - the security_check() needs established connection > to work on. > I know it but after putting the superuser check just above the security_check function make this function

Re: [HACKERS] [Review] fix dblink security hole

2008-09-16 Thread Marko Kreen
On 9/16/08, Ibrar Ahmed <[EMAIL PROTECTED]> wrote: > Here is my review of the dblink security hole patch written by Marko Kreen: Thanks for the review. > http://archives.postgresql.org/message-id/[EMAIL PROTECTED] > > 1 - The patch applies cleanly to the latest GIT repository. > 2 - Regression pa

[HACKERS] [Review] fix dblink security hole

2008-09-16 Thread Ibrar Ahmed
Hi, Here is my review of the dblink security hole patch written by Marko Kreen: http://archives.postgresql.org/message-id/[EMAIL PROTECTED] 1 - The patch applies cleanly to the latest GIT repository. 2 - Regression passed before/after the patch. 3 - I have played around with the patch a little a

[HACKERS] [Review] fix dblink security hole

2008-09-16 Thread Ibrar Ahmed
Hi, Here is my review of the dblink security hole patch written by Marko Kreen: http://archives.postgresql.org/message-id/[EMAIL PROTECTED] 1 - The patch applies cleanly to the latest GIT repository. 2 - Regression passed before/after the patch. 3 - I have played around with the patch a little