Re: [HACKERS] [Review] inherit support for foreign tables

2014-01-30 Thread Etsuro Fujita
(2014/01/28 22:01), Etsuro Fujita wrote: (2014/01/27 21:49), Shigeru Hanada wrote: Is it too big change that making ANALYZE command to handle foreign tables too even if no table name was specified? IIRC, performance issue was the reason to exclude foreign tables from auto-analyze processing. A

Re: [HACKERS] [Review] inherit support for foreign tables

2014-01-28 Thread Etsuro Fujita
(2014/01/27 21:49), Shigeru Hanada wrote: 2014-01-27 Etsuro Fujita : (2014/01/25 11:27), Shigeru Hanada wrote: Yeah, the consistency is essential for its ease of use. But I'm not sure that inherited stats ignoring foreign tables is actually useful for query optimization. What I think about the

Re: [HACKERS] [Review] inherit support for foreign tables

2014-01-27 Thread Shigeru Hanada
2014-01-27 Etsuro Fujita : > (2014/01/25 11:27), Shigeru Hanada wrote: > Yeah, the consistency is essential for its ease of use. But I'm not sure > that inherited stats ignoring foreign tables is actually useful for query > optimization. What I think about the consistency is a) the ANALYZE comman

Re: [HACKERS] [Review] inherit support for foreign tables

2014-01-26 Thread Etsuro Fujita
(2014/01/25 11:27), Shigeru Hanada wrote: 2014/1/23 Etsuro Fujita : Shigeru Hanada wrote: Though this would be debatable, in current implementation, constraints defined on a foreign table (now only NOT NULL and CHECK are supported) are not enforced during INSERT or UPDATE executed against forei

Re: [HACKERS] [Review] inherit support for foreign tables

2014-01-24 Thread Shigeru Hanada
Hi Fujita-san, Thanks for the review. 2014/1/23 Etsuro Fujita : > Shigeru Hanada wrote: >> Though this would be debatable, in current implementation, constraints >> defined on a foreign table (now only NOT NULL and CHECK are supported) >> are not enforced during INSERT or UPDATE executed against

[HACKERS] [Review] inherit support for foreign tables

2014-01-23 Thread Etsuro Fujita
Shigeru Hanada wrote: > Attached patch allows a foreign table to be a child of a table. It > also allows foreign tables to have CHECK constraints. Sorry for the delay. I started to look at this patch. > Though this would be debatable, in current implementation, constraints > defined on a foreign