Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

> On 30 Mar 2017, at 09:11, Ideriha, Takeshi > wrote: > > Thank you for prompt check! > > >As per above test steps, it doesn't produce the results and doesn't > >generate the error also. I feel this needs to be fixed. > > >As we are at the end of commitfest,

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

Thank you for prompt check! >As per above test steps, it doesn't produce the results and doesn't >generate the error also. I feel this needs to be fixed. >As we are at the end of commitfest, it is better you can move it >to next one commitfest and provide an updated patch to solve the >above

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

On Thu, Mar 30, 2017 at 1:57 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > > >+ if(connection_name == NULL) > >+ { > >+ /* > >+ * Going to here means not using AT clause in the DECLARE STATEMENT > >+ * We don't allocate a node to store the declared name because the > >+ *

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

Thank you very much for thorough review and sorry for late replay. Attched is 002_declareStmt_ecpglib_v7.patch and I haven't revised doc patch yet. >002_declareStmt_ecpglib_v5.patch: >+ struct connection *f = NULL; >+ > ecpg_init_sqlca(sqlca); > for (con = all_connections; con;) > { >- struct

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

Hi Takeshi, On 3/23/17 1:33 AM, Haribabu Kommi wrote: The test patch looks good to me. This thread has been idle for five days. Please respond with a new patch by 2017-03-30 00:00 AoE (UTC-12) or this submission will be marked "Returned with Feedback". -- -David da...@pgmasters.net --

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

Hi Haribabu, On 3/7/17 12:09 AM, Ideriha, Takeshi wrote: I tried applying your patches. But it failed... The error messages are as below. Attached 004_declareStmt_test_v5.patch is a rebased one. The rest of patches are same as older version. Regards, Ideriha, Takeshi You are signed up to