Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2009-01-08 Thread Bruce Momjian
Ryan Bradetich wrote: > Bruce, > > Thanks for adding this to the TODO. > I am planning on continuing to work on this patch after 8.4 releases. > I know we are in feature freeze and I do not want to sidetrack the > release process. Great. -- Bruce Momjian http://momjian.us Enterpris

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2009-01-08 Thread Ryan Bradetich
Bruce, Thanks for adding this to the TODO. I am planning on continuing to work on this patch after 8.4 releases. I know we are in feature freeze and I do not want to sidetrack the release process. Thanks! - Ryan On Thu, Jan 8, 2009 at 8:41 AM, Bruce Momjian wrote: > > Added to TODO: > >

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2009-01-08 Thread Bruce Momjian
Added to TODO: Reduce data row alignment requirements on some 64-bit systems * http://archives.postgresql.org/pgsql-hackers/2008-10/msg00369.php --- Ryan Bradetich wrote: > Hello all, > > Her

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2008-10-09 Thread Ryan Bradetich
Hello ITAGAKI-san, I apologize for not replying earlier, I needed to head out to work. On Thu, Oct 9, 2008 at 5:01 AM, ITAGAKI Takahiro <[EMAIL PROTECTED]> wrote: > "Ryan Bradetich" <[EMAIL PROTECTED]> wrote: >> Here is a proof-of-concept patch for reducing the alignment >> requirement for heap t

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2008-10-09 Thread Ryan Bradetich
Hello Zdenek, On Thu, Oct 9, 2008 at 12:38 AM, Zdenek Kotala <[EMAIL PROTECTED]> wrote: > Ryan Bradetich napsal(a): >> On Wed, Oct 8, 2008 at 10:59 PM, Zdenek Kotala <[EMAIL PROTECTED]> >> wrote: >> I would like to see this patch (or some variant) go in if possible. >> Since the inplace >> upgrad

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2008-10-09 Thread ITAGAKI Takahiro
"Ryan Bradetich" <[EMAIL PROTECTED]> wrote: > Here is a proof-of-concept patch for reducing the alignment > requirement for heap tuples on 64-bit systems. > > pg_depend 312 kB 296 kB > pg_description160 kB 152 kB 5 percent of gain seems reasonable f

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2008-10-09 Thread Zdenek Kotala
Ryan Bradetich napsal(a): Hello Zdenek, Hello Ryan, On Wed, Oct 8, 2008 at 10:59 PM, Zdenek Kotala <[EMAIL PROTECTED]> wrote: Just a quick look. At first point. Your change introduces new page layout version. Which is not acceptable from my point of view for 8.4 (it add I would like to se

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2008-10-08 Thread Ryan Bradetich
Hello Zdenek, On Wed, Oct 8, 2008 at 10:59 PM, Zdenek Kotala <[EMAIL PROTECTED]> wrote: > Just a quick look. At first point. Your change introduces new page layout > version. Which is not acceptable from my point of view for 8.4 (it add I would like to see this patch (or some variant) go in if po

Re: [HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2008-10-08 Thread Zdenek Kotala
Just a quick look. At first point. Your change introduces new page layout version. Which is not acceptable from my point of view for 8.4 (it add another complexity to inplace upgrade). And I guest that it maybe works fine on 64bits x86 but it will fail on SPARC and other machine which requires a

[HACKERS] [WIP] Reduce alignment requirements on 64-bit systems.

2008-10-08 Thread Ryan Bradetich
Hello all, Here is a proof-of-concept patch for reducing the alignment requirement for heap tuples on 64-bit systems. This patch passes the regression tests and a couple of other data sets I have thrown at it. I am hoping to get some early feedback on this patch so I have time to make any correct