Re: [HACKERS] 1 test fails in make installcheck-world - database "regress_ecpg_user2" does not exist

2017-08-28 Thread Ryan Murphy
> Thanks for reporting it! > My pleasure! So the initial issue didn't happen the 2nd time. So if misc_sanity was the only test failing then I guess my tests are working fine other than that. Sweet! When I get a break from work I'll review some patches! Best, Ryan

Re: [HACKERS] 1 test fails in make installcheck-world - database "regress_ecpg_user2" does not exist

2017-08-28 Thread Tom Lane
Ryan Murphy writes: > I did notice that the test seems to create a ROLE called regress_ecpg_user2: Right. > Could that implicitly create a database too? I know that I somehow have a > database named after my username / postgres role "murftown". Maybe you've got some tool somewhere that automat

Re: [HACKERS] 1 test fails in make installcheck-world - database "regress_ecpg_user2" does not exist

2017-08-28 Thread Ryan Murphy
> No, you're reading it backwards: the error is expected, but it's not > appearing in your results. I can duplicate this if I manually create > database "regress_ecpg_user2" before running ecpg's installcheck, > so I guess that's what you did. I can find no evidence that any > part of the PG regr

Re: [HACKERS] 1 test fails in make installcheck-world - database "regress_ecpg_user2" does not exist

2017-08-28 Thread Tom Lane
Ryan Murphy writes: > And when I look at that diffs file, this is what I see: > - [NO_PID]: ECPGconnect: could not open database: FATAL: database > "regress_ecpg_user2" does not exist > Why would this database not be getting created? No, you're reading it backwards: the error is expected, but

[HACKERS] 1 test fails in make installcheck-world - database "regress_ecpg_user2" does not exist

2017-08-28 Thread Ryan Murphy
Hello Postgres Hackers, I want to become more helpful to the project, reviewing more patches and starting to write more of my own - and one of the first steps is to get all the tests passing so I can confidently review patches. It almost worked... I typed "make check" and all the tests passed. T