Re: [HACKERS] 64-bit pgbench V2

2011-02-06 Thread Euler Taveira de Oliveira
Em 06-02-2011 13:09, Bruce Momjian escreveu: What happened to this idea/patch? I refactored the patch [1] to not depend on strtoll. [1] http://archives.postgresql.org/message-id/4d2cccd9@timbira.com -- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-hackers mai

Re: [HACKERS] 64-bit pgbench V2

2011-02-06 Thread Bruce Momjian
What happened to this idea/patch? --- Greg Smith wrote: > Tom Lane wrote: > > Please choose a way that doesn't introduce new portability assumptions. > > The backend gets along fine without strtoll, and I don't see why pgben

Re: [HACKERS] 64-bit pgbench V2

2010-07-12 Thread Greg Smith
Tom Lane wrote: Please choose a way that doesn't introduce new portability assumptions. The backend gets along fine without strtoll, and I don't see why pgbench should have to require it. Funny you should mention this...it turns out there is some code already there, I just didn't notice it

Re: [HACKERS] 64-bit pgbench V2

2010-07-06 Thread Robert Haas
On Tue, Jul 6, 2010 at 11:01 AM, Greg Smith wrote: > Robert Haas wrote: >> >> It doesn't seem very palatable to have multiple handwritten integer >> parsers floating around the code base either.  Maybe we should try to >> standardize something and ship it in src/port, or somesuch > > I was conside

Re: [HACKERS] 64-bit pgbench V2

2010-07-06 Thread Greg Smith
Robert Haas wrote: It doesn't seem very palatable to have multiple handwritten integer parsers floating around the code base either. Maybe we should try to standardize something and ship it in src/port, or somesuch I was considering at one point making two trips through strtol, each allowed t

Re: [HACKERS] 64-bit pgbench V2

2010-07-05 Thread Robert Haas
On Mon, Jul 5, 2010 at 8:17 PM, Tom Lane wrote: > Greg Smith writes: >> The main tricky part was figuring how to convert the \setshell >> implementation.  That uses strtol to parse the number that should have >> been returned by the shell call.  It turns out there are a stack of ways >> to do som

Re: [HACKERS] 64-bit pgbench V2

2010-07-05 Thread Tom Lane
Greg Smith writes: > The main tricky part was figuring how to convert the \setshell > implementation. That uses strtol to parse the number that should have > been returned by the shell call. It turns out there are a stack of ways > to do something similar but return 64 bits instead: Please c

[HACKERS] 64-bit pgbench V2

2010-07-05 Thread Greg Smith
Attached is an updated second rev of the patch I sent a few months ago, to expand pgbench to support database scales larger than around 4,294--where the 32-bit integer for the account number overflows in the current version. The current limit makes for about a 60GB database. Last week I ran t