Re: [HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-28 Thread Tom Lane
KaiGai Kohei <[EMAIL PROTECTED]> writes: > In my understanding, the matter comes from the mixture of two kind of > tuples. The one has object identifier, and the other don't have. > It seems to me the current implementation assumes fetched tuples have > proper rowtype which matches to the current t

Re: [HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-27 Thread KaiGai Kohei
Tom Lane wrote: > KaiGai Kohei <[EMAIL PROTECTED]> writes: >> If my understanding is correct, the following patch can fix the matters. > >> !if (ExecContextForcesOids(ps, &hasoid) && >> !hasoid != tupdesc->tdhasoid) >> return false; >> --- 243,249 >> !if (Exec

Re: [HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-27 Thread Tom Lane
KaiGai Kohei <[EMAIL PROTECTED]> writes: > If my understanding is correct, the following patch can fix the matters. > ! if (ExecContextForcesOids(ps, &hasoid) && > ! hasoid != tupdesc->tdhasoid) > return false; > --- 243,249 > ! if (ExecContextForcesOids(ps,

Re: [HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-26 Thread KaiGai Kohei
Heikki Linnakangas wrote: > This patch: > >> commit 35ad25ad66fa3999bbc0bb59ca13cef3d750fb07 >> Author: Tom Lane <[EMAIL PROTECTED]> >> Date: Sat Jul 26 19:15:35 2008 + >> >> As noted by Andrew Gierth, there's really no need any more to force a >> junk >> filter to be used when INSE

Re: [HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-05 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > This patch: >> As noted by Andrew Gierth, there's really no need any more to force a junk >> filter to be used when INSERT or SELECT INTO has a plan that returns raw >> disk tuples. > made this test case crash: > CREATE TABLE xtable (padding char(

Re: [HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-05 Thread Heikki Linnakangas
Alvaro Herrera wrote: Heikki Linnakangas wrote: made this test case crash: CREATE TABLE xtable (padding char(2000)) WITH OIDS; INSERT INTO xtable VALUES('1'); ALTER TABLE xtable SET WITHOUT OIDS; INSERT INTO xtable (SELECT * FROM xtable); with assertion failure: TRAP: FailedAssertion("!(!(t

Re: [HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-05 Thread Alvaro Herrera
Heikki Linnakangas wrote: > made this test case crash: > > CREATE TABLE xtable (padding char(2000)) WITH OIDS; > INSERT INTO xtable VALUES('1'); > ALTER TABLE xtable SET WITHOUT OIDS; > INSERT INTO xtable (SELECT * FROM xtable); > > with assertion failure: > > TRAP: FailedAssertion("!(!(tup->t_da

[HACKERS] A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

2008-11-05 Thread Heikki Linnakangas
This patch: commit 35ad25ad66fa3999bbc0bb59ca13cef3d750fb07 Author: Tom Lane <[EMAIL PROTECTED]> Date: Sat Jul 26 19:15:35 2008 + As noted by Andrew Gierth, there's really no need any more to force a junk filter to be used when INSERT or SELECT INTO has a plan that returns raw