Alvaro Herrera writes:
> I think odd coding this was introduced recently because of the
> pg_resetxlog -> pg_resetwal renaming.
Dunno about that, but certainly somebody fat-fingered a refactoring
there. The 9.6 code looks quite different but doesn't seem to be
doing anything silly.
a.akent...@postgrespro.ru writes:
> I've came across a weird bit in pg_upgrade/exec.c
> We have a function check_bin_dir() which goes like this (old_cluster and
> new_cluster are global variables):
> void check_bin_dir(ClusterInfo *cluster)
> {
> ...
> get_bin_version(&old_cluster);
>
a.akent...@postgrespro.ru wrote:
> This function has two calls:
> check_bin_dir(&old_cluster);
> check_bin_dir(&new_cluster);
>
> I'd like to substitute these last two lines with this:
> get_bin_version(cluster);
Odd indeed. One would think that if a cluster variable is passed as
parameter, the
Hello!
I've came across a weird bit in pg_upgrade/exec.c
We have a function check_bin_dir() which goes like this (old_cluster and
new_cluster are global variables):
void check_bin_dir(ClusterInfo *cluster)
{
...
get_bin_version(&old_cluster);
get_bin_version(&new_cluster);
...
}
