Re: [HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-02-20 Thread Tomas Vondra
On 21.2.2015 01:45, Peter Geoghegan wrote: > On Fri, Feb 20, 2015 at 4:42 PM, Tomas Vondra > wrote: >> Isn't this patch about adding abbreviated keys for Numeric data type? >> That's how I understood it, and looking into numeric_sortsup.patch seems >> to confirm that. >> >> There's another patch f

Re: [HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-02-20 Thread Peter Geoghegan
On Fri, Feb 20, 2015 at 4:42 PM, Tomas Vondra wrote: > Isn't this patch about adding abbreviated keys for Numeric data type? > That's how I understood it, and looking into numeric_sortsup.patch seems > to confirm that. > > There's another patch for Datum, but that's a different thread. Right...so

Re: [HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-02-20 Thread Tomas Vondra
On 21.2.2015 01:17, Peter Geoghegan wrote: > On Fri, Feb 20, 2015 at 4:11 PM, Tomas Vondra > wrote: >>> So you're testing both the patches (numeric + datum tuplesort) at the >>> same time? >> >> No, I was just testing two similar patches separately. I.e. master vs. >> each patch separately. > > W

Re: [HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-02-20 Thread Peter Geoghegan
On Fri, Feb 20, 2015 at 4:11 PM, Tomas Vondra wrote: >> So you're testing both the patches (numeric + datum tuplesort) at the >> same time? > > No, I was just testing two similar patches separately. I.e. master vs. > each patch separately. Well, you're sorting numeric here, no? Why should it matt

Re: [HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-02-20 Thread Tomas Vondra
On 21.2.2015 00:14, Peter Geoghegan wrote: > On Fri, Feb 20, 2015 at 1:33 PM, Tomas Vondra > wrote: >> For example with the same percentile_disc() test as in the other >> thread: >> >> create table stuff as select random()::numeric as randnum from >> generate_series(1,100); >> >> analyze st

Re: [HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-02-20 Thread Peter Geoghegan
On Fri, Feb 20, 2015 at 1:33 PM, Tomas Vondra wrote: > For example with the same percentile_disc() test as in the other thread: > >create table stuff as select random()::numeric as randnum >from generate_series(1,100); > >analyze stuff; > >select percent

Re: [HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-02-20 Thread Tomas Vondra
Hi, On 26.1.2015 17:43, Andrew Gierth wrote: > Another spinoff from the abbreviation discussion. Peter Geoghegan > suggested on IRC that numeric would benefit from abbreviation, and > indeed it does (in some cases by a factor of about 6-7x or more, because > numeric comparison is no speed demon).

[HACKERS] Abbreviated keys for Numeric (was: Re: B-Tree support function number 3 (strxfrm() optimization))

2015-01-26 Thread Andrew Gierth
Another spinoff from the abbreviation discussion. Peter Geoghegan suggested on IRC that numeric would benefit from abbreviation, and indeed it does (in some cases by a factor of about 6-7x or more, because numeric comparison is no speed demon). This patch abbreviates numerics to a weight+initial d