Re: [HACKERS] Add pg_settings.pending_restart column

2015-05-14 Thread Peter Eisentraut
On 4/22/15 2:32 AM, Michael Paquier wrote: > Attached is a rebased patch with previous comments addressed as I was > looking at it. > Switching this patch as "Ready for committer". Committed, thanks. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Add pg_settings.pending_restart column

2015-04-21 Thread Michael Paquier
On Thu, Mar 5, 2015 at 12:04 PM, Peter Eisentraut wrote: > On 2/17/15 10:45 AM, Robert Haas wrote: >> You don't really need the "else" here, and in parallel cases: >> >> if (*conf->variable != newval) >> { >> +record->status |= GUC_

Re: [HACKERS] Add pg_settings.pending_restart column

2015-03-04 Thread Peter Eisentraut
On 2/15/15 3:41 AM, David G Johnston wrote: > Otherwise it seems fine but I cannot help but feel that false positives are > possible; though nothing that doesn't already exist. Mainly, is the change > going to end up only affect the reset or default value but not the currently > active value? I d

Re: [HACKERS] Add pg_settings.pending_restart column

2015-03-04 Thread Peter Eisentraut
On 2/17/15 10:45 AM, Robert Haas wrote: > You don't really need the "else" here, and in parallel cases: > > if (*conf->variable != newval) > { > +record->status |= GUC_PENDING_RESTART; > ereport(elevel, >

Re: [HACKERS] Add pg_settings.pending_restart column

2015-02-17 Thread Robert Haas
On Sat, Feb 14, 2015 at 10:18 PM, Peter Eisentraut wrote: > When managing configuration changes through automatic systems like Chef > or Puppet, there is a problem: How do you manage changes requiring a > restart? > > Generally, you'd set it up so that when a configuration file is changed, > the s

Re: [HACKERS] Add pg_settings.pending_restart column

2015-02-15 Thread David G Johnston
Peter Eisentraut-2 wrote > So here is a patch for that. It adds a column pending_restart to > pg_settings that is true when the configuration file contains a changed > setting that requires a restart. We already had the logic to detect > such changes, for producing the log entry. I have also set

[HACKERS] Add pg_settings.pending_restart column

2015-02-14 Thread Peter Eisentraut
When managing configuration changes through automatic systems like Chef or Puppet, there is a problem: How do you manage changes requiring a restart? Generally, you'd set it up so that when a configuration file is changed, the server is reloaded. But for settings that require a restart, well, I d