Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-12-04 Thread Magnus Hagander
On Thu, Nov 17, 2011 at 09:50, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Tom Lane t...@sss.pgh.pa.us writes: What you've got here could be useful to people who use emacs and understand they've got to hand-check the results.  I'm not sure how much further it'd be useful to go. Agreed.

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-12-04 Thread Dimitri Fontaine
Magnus Hagander mag...@hagander.net writes: I can also maintain that in a separate git repository on github, but that only reduces the already very thin population that could find it useful. Since people seem to be less than super-enthusiastic about putting into the core distro, perhaps it

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-17 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: What you've got here could be useful to people who use emacs and understand they've got to hand-check the results. I'm not sure how much further it'd be useful to go. Agreed. That's the reason why I'm proposing src/tools/editors in the first place. I find

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-16 Thread Dimitri Fontaine
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Dimitri Fontaine dimi...@2ndquadrant.fr writes: What about adding that into src/tools/editors/pgsrc.el? Should I add an item for that in the commit fest? -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-16 Thread Robert Haas
On Tue, Nov 15, 2011 at 5:41 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Dimitri Fontaine dimi...@2ndquadrant.fr writes: Dimitri Fontaine dimi...@2ndquadrant.fr writes: What about adding that into src/tools/editors/pgsrc.el? Should I add an item for that in the commit fest? Sounds

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-16 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: Should I add an item for that in the commit fest? Sounds like a good idea. Done: https://commitfest.postgresql.org/action/patch_view?id=707 Note: I might also add support for equalfuncs and copyfuncs while at, been doing that again and I guess I would

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-16 Thread Peter Eisentraut
On ons, 2011-11-09 at 20:14 +0100, Dimitri Fontaine wrote: The task in $subject is something I will have to do repeatedly for completing the Command Trigger patch. I've been doing some of them manually, covering initdb. Then I've been scripting away the editing. The script takes a Node

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-16 Thread Dimitri Fontaine
Peter Eisentraut pete...@gmx.net writes: This is a massive amount of code that very few people in our community will use, and very few be able to maintain it, too. If you want to make a lasting contribution on this area, write a program that generates the node handling functionality

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-16 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Peter Eisentraut pete...@gmx.net writes: This is a massive amount of code that very few people in our community will use, and very few be able to maintain it, too. It's not that massive, at least not as it stands, although I agree it looks

Re: [HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-11 Thread Dimitri Fontaine
Dimitri Fontaine dimi...@2ndquadrant.fr writes: What about adding that into src/tools/editors/pgsrc.el? Of course after having used it some more, I fixed a bug and added a function to start from the readfunc node name rather than the enum node number in the interactive calls. Please find

[HACKERS] Adding Node support in outfuncs.c and readfuncs.c

2011-11-09 Thread Dimitri Fontaine
Hi, The task in $subject is something I will have to do repeatedly for completing the Command Trigger patch. I've been doing some of them manually, covering initdb. Then I've been scripting away the editing. The script takes a Node number as input (because that's what you're given in ERROR