Re: [HACKERS] Allow on/off as input texts for boolean.

2009-03-09 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: Peter Eisentraut pete...@gmx.net wrote: ITAGAKI Takahiro wrote: Here is a patch to allow 'on' and 'off' as input texts for boolean. Regarding your FIXME comment, I think parse_bool* should be in bool.c and declared in builtins.h, which guc.c already includes.

Re: [HACKERS] Allow on/off as input texts for boolean.

2009-02-20 Thread ITAGAKI Takahiro
Peter Eisentraut pete...@gmx.net wrote: ITAGAKI Takahiro wrote: Here is a patch to allow 'on' and 'off' as input texts for boolean. Regarding your FIXME comment, I think parse_bool* should be in bool.c and declared in builtins.h, which guc.c already includes. (Conceptually, the valid

Re: [HACKERS] Allow on/off as input texts for boolean.

2009-02-19 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: Here is a patch to allow 'on' and 'off' as input texts for boolean. Duplicated boolean parsers in parse_bool() and boolin() are merged into a new parse_bool_with_len(). Regarding your FIXME comment, I think parse_bool* should be in bool.c and declared in builtins.h,

[HACKERS] Allow on/off as input texts for boolean.

2009-02-16 Thread ITAGAKI Takahiro
ITAGAKI Takahiro itagaki.takah...@oss.ntt.co.jp wrote: - Postgres interprets 'on' as true and 'off' as false in configuration parameters, but they are not accepted in sql-boolean. Is it a design? or should we add a parser for 'on' and 'off' ? I'd like to allow 'on' and 'off' in