Re: [HACKERS] Another extensions bug

2011-08-24 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: On further reflection, it seems more in keeping with the coding elsewhere in this module to treat this as a distinct dependency type, instead of confusing it with a NORMAL dependency. There's no actual functional difference at the moment, but more info is

Re: [HACKERS] Another extensions bug

2011-08-24 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Hence, proposed patch attached (which also improves some of the related comments). +1 on the idea, although I'm not in a position to further review or play with the patch today. Further testing shows that

[HACKERS] Another extensions bug

2011-08-23 Thread Tom Lane
Whilst testing the schema-creation-permissions scenario that Kaigai-san recently pointed out, I happened to do this: regression=# create schema c; CREATE SCHEMA regression=# create extension cube with schema c; CREATE EXTENSION regression=# drop schema c; DROP SCHEMA ... er, what? I was

Re: [HACKERS] Another extensions bug

2011-08-23 Thread Tom Lane
I wrote: ... So I'm thinking this recursive call should just pass DEPFLAG_NORMAL in all cases: On further reflection, it seems more in keeping with the coding elsewhere in this module to treat this as a distinct dependency type, instead of confusing it with a NORMAL dependency. There's no